* [PATCH] net: ethernet: dwmac-sun8i: Use the correct function in exit path
@ 2019-11-10 11:30 Corentin Labbe
2019-11-11 23:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2019-11-10 11:30 UTC (permalink / raw)
To: alexandre.torgue, davem, joabreu, mripard, peppe.cavallaro, wens
Cc: linux-arm-kernel, linux-kernel, netdev, linux-sunxi,
Corentin Labbe, # v4 . 15+
When PHY is not powered, the probe function fail and some resource are
still unallocated.
Furthermore some BUG happens:
dwmac-sun8i 5020000.ethernet: EMAC reset timeout
------------[ cut here ]------------
kernel BUG at /linux-next/net/core/dev.c:9844!
So let's use the right function (stmmac_pltfr_remove) in the error path.
Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
Cc: <stable@vger.kernel.org> # v4.15+
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index eefb06d918c8..1c8d84ed8410 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -1227,7 +1227,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
dwmac_mux:
sun8i_dwmac_unset_syscon(gmac);
dwmac_exit:
- sun8i_dwmac_exit(pdev, plat_dat->bsp_priv);
+ stmmac_pltfr_remove(pdev);
return ret;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: dwmac-sun8i: Use the correct function in exit path
2019-11-10 11:30 [PATCH] net: ethernet: dwmac-sun8i: Use the correct function in exit path Corentin Labbe
@ 2019-11-11 23:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-11 23:14 UTC (permalink / raw)
To: clabbe
Cc: alexandre.torgue, joabreu, mripard, peppe.cavallaro, wens,
linux-arm-kernel, linux-kernel, netdev, linux-sunxi, stable
From: Corentin Labbe <clabbe@baylibre.com>
Date: Sun, 10 Nov 2019 11:30:48 +0000
> When PHY is not powered, the probe function fail and some resource are
> still unallocated.
> Furthermore some BUG happens:
> dwmac-sun8i 5020000.ethernet: EMAC reset timeout
> ------------[ cut here ]------------
> kernel BUG at /linux-next/net/core/dev.c:9844!
>
> So let's use the right function (stmmac_pltfr_remove) in the error path.
>
> Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
> Cc: <stable@vger.kernel.org> # v4.15+
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-12 20:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-10 11:30 [PATCH] net: ethernet: dwmac-sun8i: Use the correct function in exit path Corentin Labbe
2019-11-11 23:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).