* linux-next: Fixes tag needs some work in the vfs-fixes tree
@ 2019-11-10 22:09 Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2019-11-10 22:09 UTC (permalink / raw)
To: Al Viro; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
Hi all,
In commit
bcf0d9d4b769 ("ecryptfs: fix unlink and rmdir in face of underlying fs modifications")
Fixes tag
Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: Fixes tag needs some work in the vfs-fixes tree
@ 2021-03-25 20:51 Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2021-03-25 20:51 UTC (permalink / raw)
To: Al Viro; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
Hi all,
In commit
595a48eb7b48 ("hostfs: fix memory handling in follow_link()")
Fixes tag
Fixes: 52b209f7b848 "get rid of hostfs_read_inode()" # v2.6.35+
has these problem(s):
- Subject has leading but no trailing quotes
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
The version comment is unneeded as it can be trivially gained from
"git describe".
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Fixes tag needs some work in the vfs-fixes tree
2020-11-12 21:02 Stephen Rothwell
@ 2020-11-12 21:14 ` Al Viro
0 siblings, 0 replies; 5+ messages in thread
From: Al Viro @ 2020-11-12 21:14 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
On Fri, Nov 13, 2020 at 08:02:39AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 5f85b351d3d6 ("fix return values of seq_read_iter()")
>
> Fixes tag
>
> Fixes: d4d50710a8b (seq_file: add seq_read_iter)
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
Dealt with and force-pushed...
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
>
> Also, just use
>
> git log -1 --format='Fixes: %h ("%s")' <commit>
>
> to generate Fixes tags.
OK, will keep that in mind next time...
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: Fixes tag needs some work in the vfs-fixes tree
@ 2020-11-12 21:02 Stephen Rothwell
2020-11-12 21:14 ` Al Viro
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-11-12 21:02 UTC (permalink / raw)
To: Al Viro; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
Hi all,
In commit
5f85b351d3d6 ("fix return values of seq_read_iter()")
Fixes tag
Fixes: d4d50710a8b (seq_file: add seq_read_iter)
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Also, just use
git log -1 --format='Fixes: %h ("%s")' <commit>
to generate Fixes tags.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: Fixes tag needs some work in the vfs-fixes tree
@ 2019-10-21 20:44 Stephen Rothwell
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2019-10-21 20:44 UTC (permalink / raw)
To: Al Viro; +Cc: Linux Next Mailing List, Linux Kernel Mailing List, Guillem Jover
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
Hi all,
In commit
de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")
Fixes tag
Fixes: 7a074e96 ("aio: implement io_pgetevents")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-25 20:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-10 22:09 linux-next: Fixes tag needs some work in the vfs-fixes tree Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 20:51 Stephen Rothwell
2020-11-12 21:02 Stephen Rothwell
2020-11-12 21:14 ` Al Viro
2019-10-21 20:44 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).