* [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE
@ 2019-11-11 8:59 Anders Roxell
2019-11-11 10:26 ` Will Deacon
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Anders Roxell @ 2019-11-11 8:59 UTC (permalink / raw)
To: catalin.marinas
Cc: will, john.garry, linux-arm-kernel, linux-kernel, Anders Roxell
When building allmodconfig KCONFIG_ALLCONFIG=$(pwd)/arch/arm64/configs/defconfig
CONFIG_CMDLINE_FORCE gets enabled. Which forces the user to pass the
full cmdline to CONFIG_CMDLINE="...".
Rework so that CONFIG_CMDLINE_FORCE gets set only if CONFIG_CMDLINE is
set to something except an empty string.
Suggested-by: John Garry <john.garry@huawei.com>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 50df79d4aa3b..64764ca92fca 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -1629,6 +1629,7 @@ config CMDLINE
config CMDLINE_FORCE
bool "Always use the default kernel command string"
+ depends on CMDLINE != ""
help
Always use the default kernel command string, even if the boot
loader passes other arguments to the kernel.
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE
2019-11-11 8:59 [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE Anders Roxell
@ 2019-11-11 10:26 ` Will Deacon
2019-11-11 14:14 ` John Garry
2019-11-11 18:23 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2019-11-11 10:26 UTC (permalink / raw)
To: Anders Roxell; +Cc: catalin.marinas, john.garry, linux-arm-kernel, linux-kernel
On Mon, Nov 11, 2019 at 09:59:56AM +0100, Anders Roxell wrote:
> When building allmodconfig KCONFIG_ALLCONFIG=$(pwd)/arch/arm64/configs/defconfig
> CONFIG_CMDLINE_FORCE gets enabled. Which forces the user to pass the
> full cmdline to CONFIG_CMDLINE="...".
>
> Rework so that CONFIG_CMDLINE_FORCE gets set only if CONFIG_CMDLINE is
> set to something except an empty string.
>
> Suggested-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 50df79d4aa3b..64764ca92fca 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1629,6 +1629,7 @@ config CMDLINE
>
> config CMDLINE_FORCE
> bool "Always use the default kernel command string"
> + depends on CMDLINE != ""
> help
> Always use the default kernel command string, even if the boot
> loader passes other arguments to the kernel.
Acked-by: Will Deacon <will@kernel.org>
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE
2019-11-11 8:59 [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE Anders Roxell
2019-11-11 10:26 ` Will Deacon
@ 2019-11-11 14:14 ` John Garry
2019-11-11 18:23 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: John Garry @ 2019-11-11 14:14 UTC (permalink / raw)
To: Anders Roxell, catalin.marinas; +Cc: will, linux-kernel, linux-arm-kernel
On 11/11/2019 08:59, Anders Roxell wrote:
> When building allmodconfig KCONFIG_ALLCONFIG=$(pwd)/arch/arm64/configs/defconfig
> CONFIG_CMDLINE_FORCE gets enabled. Which forces the user to pass the
> full cmdline to CONFIG_CMDLINE="...".
>
> Rework so that CONFIG_CMDLINE_FORCE gets set only if CONFIG_CMDLINE is
> set to something except an empty string.
>
> Suggested-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
This looks ok.
Were you also going to propose a patch to introduce a LITTLE ENDIAN
config option?
For me, this would mean that ACPI module is built for allmodconfig,
which is a good thing.
Thanks,
john
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 50df79d4aa3b..64764ca92fca 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1629,6 +1629,7 @@ config CMDLINE
>
> config CMDLINE_FORCE
> bool "Always use the default kernel command string"
> + depends on CMDLINE != ""
> help
> Always use the default kernel command string, even if the boot
> loader passes other arguments to the kernel.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE
2019-11-11 8:59 [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE Anders Roxell
2019-11-11 10:26 ` Will Deacon
2019-11-11 14:14 ` John Garry
@ 2019-11-11 18:23 ` Catalin Marinas
2 siblings, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2019-11-11 18:23 UTC (permalink / raw)
To: Anders Roxell; +Cc: will, john.garry, linux-arm-kernel, linux-kernel
On Mon, Nov 11, 2019 at 09:59:56AM +0100, Anders Roxell wrote:
> When building allmodconfig KCONFIG_ALLCONFIG=$(pwd)/arch/arm64/configs/defconfig
> CONFIG_CMDLINE_FORCE gets enabled. Which forces the user to pass the
> full cmdline to CONFIG_CMDLINE="...".
>
> Rework so that CONFIG_CMDLINE_FORCE gets set only if CONFIG_CMDLINE is
> set to something except an empty string.
>
> Suggested-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Queued for 5.5.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-11 18:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 8:59 [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE Anders Roxell
2019-11-11 10:26 ` Will Deacon
2019-11-11 14:14 ` John Garry
2019-11-11 18:23 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).