* [PATCH][next] cxgb4: remove redundant assignment to hdr_len
@ 2019-11-11 12:44 Colin King
2019-11-12 6:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-11-11 12:44 UTC (permalink / raw)
To: Vishal Kulkarni, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable hdr_len is being assigned a value that is never read.
The assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index e346830ebca9..09059adc3067 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -3810,7 +3810,6 @@ int cxgb4_ethofld_rx_handler(struct sge_rspq *q, const __be64 *rsp,
eosw_txq->state ==
CXGB4_EO_STATE_FLOWC_CLOSE_REPLY) &&
eosw_txq->cidx == eosw_txq->flowc_idx)) {
- hdr_len = skb->len;
flits = DIV_ROUND_UP(skb->len, 8);
if (eosw_txq->state ==
CXGB4_EO_STATE_FLOWC_OPEN_REPLY)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] cxgb4: remove redundant assignment to hdr_len
2019-11-11 12:44 [PATCH][next] cxgb4: remove redundant assignment to hdr_len Colin King
@ 2019-11-12 6:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-12 6:05 UTC (permalink / raw)
To: colin.king; +Cc: vishal, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 11 Nov 2019 12:44:13 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable hdr_len is being assigned a value that is never read.
> The assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-12 6:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 12:44 [PATCH][next] cxgb4: remove redundant assignment to hdr_len Colin King
2019-11-12 6:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).