* [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon
@ 2019-11-12 13:05 Colin King
2019-11-12 13:27 ` Andrew Lunn
2019-11-12 19:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-11-12 13:05 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S . Miller,
Iwan R Timmer, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a stray semicolon in an if statement that will cause a dev_err
message to be printed unconditionally. Fix this by removing the stray
semicolon.
Addresses-Coverity: ("Stay semicolon")
Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index e8bf6ac1e0f4..3bd988529178 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -5317,7 +5317,7 @@ static void mv88e6xxx_port_mirror_del(struct dsa_switch *ds, int port,
if (chip->info->ops->set_egress_port(chip,
direction,
dsa_upstream_port(ds,
- port)));
+ port)))
dev_err(ds->dev, "failed to set egress port\n");
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon
2019-11-12 13:05 [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon Colin King
@ 2019-11-12 13:27 ` Andrew Lunn
2019-11-12 19:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-11-12 13:27 UTC (permalink / raw)
To: Colin King
Cc: Vivien Didelot, Florian Fainelli, David S . Miller,
Iwan R Timmer, netdev, kernel-janitors, linux-kernel
On Tue, Nov 12, 2019 at 01:05:23PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a stray semicolon in an if statement that will cause a dev_err
> message to be printed unconditionally. Fix this by removing the stray
> semicolon.
>
> Addresses-Coverity: ("Stay semicolon")
> Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon
2019-11-12 13:05 [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon Colin King
2019-11-12 13:27 ` Andrew Lunn
@ 2019-11-12 19:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-12 19:32 UTC (permalink / raw)
To: colin.king
Cc: andrew, vivien.didelot, f.fainelli, irtimmer, netdev,
kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 Nov 2019 13:05:23 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a stray semicolon in an if statement that will cause a dev_err
> message to be printed unconditionally. Fix this by removing the stray
> semicolon.
>
> Addresses-Coverity: ("Stay semicolon")
> Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-12 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 13:05 [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon Colin King
2019-11-12 13:27 ` Andrew Lunn
2019-11-12 19:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).