* [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'
@ 2019-11-14 10:04 Uwe Kleine-König
2019-11-14 10:14 ` Rasmus Villemoes
2019-11-14 10:24 ` Petr Mladek
0 siblings, 2 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2019-11-14 10:04 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches, Rasmus Villemoes, Petr Mladek,
Andy Shevchenko
Cc: linux-kernel, kernel
This extension was introduced in commit 57f5677e535b ("printf: add
support for printing symbolic error names").
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6fcc66afb088..31cd9b767c1e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6022,7 +6022,7 @@ sub process {
while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
$specifier = $1;
$extension = $2;
- if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
+ if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
$bad_specifier = $specifier;
last;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'
2019-11-14 10:04 [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe' Uwe Kleine-König
@ 2019-11-14 10:14 ` Rasmus Villemoes
2019-11-14 10:24 ` Petr Mladek
1 sibling, 0 replies; 5+ messages in thread
From: Rasmus Villemoes @ 2019-11-14 10:14 UTC (permalink / raw)
To: Uwe Kleine-König, Andy Whitcroft, Joe Perches, Petr Mladek,
Andy Shevchenko
Cc: linux-kernel, kernel
On 14/11/2019 11.04, Uwe Kleine-König wrote:
> This extension was introduced in commit 57f5677e535b ("printf: add
> support for printing symbolic error names").
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Ack, of course. Petr, I think it makes most sense if this goes via your
tree unless there are other checkpatch patches touching the same place
(which I doubt, as I think we'd know about other new extensions).
Rasmus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'
2019-11-14 10:04 [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe' Uwe Kleine-König
2019-11-14 10:14 ` Rasmus Villemoes
@ 2019-11-14 10:24 ` Petr Mladek
2019-11-14 10:33 ` Uwe Kleine-König
1 sibling, 1 reply; 5+ messages in thread
From: Petr Mladek @ 2019-11-14 10:24 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Andy Whitcroft, Joe Perches, Rasmus Villemoes, Andy Shevchenko,
linux-kernel, kernel
On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote:
> This extension was introduced in commit 57f5677e535b ("printf: add
> support for printing symbolic error names").
Great catch!
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb088..31cd9b767c1e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6022,7 +6022,7 @@ sub process {
> while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> $specifier = $1;
> $extension = $2;
> - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> + if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
I am going to push it into printk.git. I will just change the ordering
"eE" -> "Ee". So that it follows the existing convention.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'
2019-11-14 10:24 ` Petr Mladek
@ 2019-11-14 10:33 ` Uwe Kleine-König
2019-11-14 14:01 ` Petr Mladek
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2019-11-14 10:33 UTC (permalink / raw)
To: Petr Mladek
Cc: Andy Whitcroft, Joe Perches, Rasmus Villemoes, Andy Shevchenko,
linux-kernel, kernel
On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote:
> On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote:
> > This extension was introduced in commit 57f5677e535b ("printf: add
> > support for printing symbolic error names").
>
> Great catch!
It wasn't hard to catch. checkpatch pelted me with bogus warnings when I
started to make use of %pe :-)
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > scripts/checkpatch.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 6fcc66afb088..31cd9b767c1e 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -6022,7 +6022,7 @@ sub process {
> > while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> > $specifier = $1;
> > $extension = $2;
> > - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> > + if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
>
> I am going to push it into printk.git. I will just change the ordering
> "eE" -> "Ee". So that it follows the existing convention.
Fine for me. Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'
2019-11-14 10:33 ` Uwe Kleine-König
@ 2019-11-14 14:01 ` Petr Mladek
0 siblings, 0 replies; 5+ messages in thread
From: Petr Mladek @ 2019-11-14 14:01 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Andy Whitcroft, Joe Perches, Rasmus Villemoes, Andy Shevchenko,
linux-kernel, kernel
On Thu 2019-11-14 11:33:50, Uwe Kleine-König wrote:
> On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote:
> > On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote:
> > > This extension was introduced in commit 57f5677e535b ("printf: add
> > > support for printing symbolic error names").
> >
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > index 6fcc66afb088..31cd9b767c1e 100755
> > > --- a/scripts/checkpatch.pl
> > > +++ b/scripts/checkpatch.pl
> > > @@ -6022,7 +6022,7 @@ sub process {
> > > while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> > > $specifier = $1;
> > > $extension = $2;
> > > - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> > > + if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
> >
> > I am going to push it into printk.git. I will just change the ordering
> > "eE" -> "Ee". So that it follows the existing convention.
>
> Fine for me. Thanks
The patch is committed in printk.git, branch for-5.5.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-14 14:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 10:04 [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe' Uwe Kleine-König
2019-11-14 10:14 ` Rasmus Villemoes
2019-11-14 10:24 ` Petr Mladek
2019-11-14 10:33 ` Uwe Kleine-König
2019-11-14 14:01 ` Petr Mladek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).