* [PATCH -next] ubi: remove unused variable 'err'
@ 2019-11-14 7:22 YueHaibing
2019-11-14 10:00 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-11-14 7:22 UTC (permalink / raw)
To: richard, miquel.raynal, vigneshr, gregkh
Cc: linux-mtd, linux-kernel, YueHaibing
drivers/mtd/ubi/debug.c:512:6: warning: unused variable 'err' [-Wunused-variable]
commit 3427dd213259 ("mtd: no need to check return value
of debugfs_create functions") leave this variable not used.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mtd/ubi/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c
index f8d3752..8dba1b5 100644
--- a/drivers/mtd/ubi/debug.c
+++ b/drivers/mtd/ubi/debug.c
@@ -509,7 +509,7 @@ static const struct file_operations eraseblk_count_fops = {
*/
int ubi_debugfs_init_dev(struct ubi_device *ubi)
{
- int err, n;
+ int n;
unsigned long ubi_num = ubi->ubi_num;
struct ubi_debug_info *d = &ubi->dbg;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ubi: remove unused variable 'err'
2019-11-14 7:22 [PATCH -next] ubi: remove unused variable 'err' YueHaibing
@ 2019-11-14 10:00 ` Miquel Raynal
2019-11-14 13:13 ` Yuehaibing
0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2019-11-14 10:00 UTC (permalink / raw)
To: YueHaibing; +Cc: richard, vigneshr, gregkh, linux-mtd, linux-kernel
Hi Yue,
YueHaibing <yuehaibing@huawei.com> wrote on Thu, 14 Nov 2019 15:22:36
+0800:
> drivers/mtd/ubi/debug.c:512:6: warning: unused variable 'err' [-Wunused-variable]
>
> commit 3427dd213259 ("mtd: no need to check return value
> of debugfs_create functions") leave this variable not used.
Thanks for the fix but I already fixed this trivial issue, I just
did not had time yesterday night to push it, now it is done. It will
be part of tomorrow's linux-next release.
Cheers,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ubi: remove unused variable 'err'
2019-11-14 10:00 ` Miquel Raynal
@ 2019-11-14 13:13 ` Yuehaibing
0 siblings, 0 replies; 3+ messages in thread
From: Yuehaibing @ 2019-11-14 13:13 UTC (permalink / raw)
To: Miquel Raynal; +Cc: richard, vigneshr, gregkh, linux-mtd, linux-kernel
On 2019/11/14 18:00, Miquel Raynal wrote:
> Hi Yue,
>
> YueHaibing <yuehaibing@huawei.com> wrote on Thu, 14 Nov 2019 15:22:36
> +0800:
>
>> drivers/mtd/ubi/debug.c:512:6: warning: unused variable 'err' [-Wunused-variable]
>>
>> commit 3427dd213259 ("mtd: no need to check return value
>> of debugfs_create functions") leave this variable not used.
>
> Thanks for the fix but I already fixed this trivial issue, I just
> did not had time yesterday night to push it, now it is done. It will
> be part of tomorrow's linux-next release.
Ok, thanks for the info.
>
> Cheers,
> Miquèl
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-14 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 7:22 [PATCH -next] ubi: remove unused variable 'err' YueHaibing
2019-11-14 10:00 ` Miquel Raynal
2019-11-14 13:13 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).