* [PATCH] x86/build/vdso: remove meaningless CFLAGS_REMOVE_*.o
@ 2019-11-14 15:49 Masahiro Yamada
2019-11-15 11:51 ` [tip: x86/build] x86/build/vdso: Remove " tip-bot2 for Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-11-14 15:49 UTC (permalink / raw)
To: x86, Ingo Molnar, Thomas Gleixner, Borislav Petkov, H . Peter Anvin
Cc: Masahiro Yamada, Andy Lutomirski, Ingo Molnar, linux-kernel
CFLAGS_REMOVE_*.o syntax is used to drop particular flags when
building objects from C files. It has no effect for assembly files.
vdso-note.o is compiled from the assembly file, vdso-note.S, hence
CFLAGS_REMOVE_vdso-note.o is meaningless.
Neither vvar.c nor vvar.S is found in the vdso directory. Since there
is no source file to create vvar.o, CFLAGS_REMOVE_vvar.o is also
meaningless.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/x86/entry/vdso/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index 0f2154106d01..2b75e80f6b41 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -87,11 +87,9 @@ $(vobjs): KBUILD_CFLAGS := $(filter-out $(GCC_PLUGINS_CFLAGS) $(RETPOLINE_CFLAGS
#
# vDSO code runs in userspace and -pg doesn't help with profiling anyway.
#
-CFLAGS_REMOVE_vdso-note.o = -pg
CFLAGS_REMOVE_vclock_gettime.o = -pg
CFLAGS_REMOVE_vdso32/vclock_gettime.o = -pg
CFLAGS_REMOVE_vgetcpu.o = -pg
-CFLAGS_REMOVE_vvar.o = -pg
#
# X32 processes use x32 vDSO to access 64bit kernel data.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: x86/build] x86/build/vdso: Remove meaningless CFLAGS_REMOVE_*.o
2019-11-14 15:49 [PATCH] x86/build/vdso: remove meaningless CFLAGS_REMOVE_*.o Masahiro Yamada
@ 2019-11-15 11:51 ` tip-bot2 for Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Masahiro Yamada @ 2019-11-15 11:51 UTC (permalink / raw)
To: linux-tip-commits
Cc: Masahiro Yamada, Borislav Petkov, Andy Lutomirski,
H. Peter Anvin, Ingo Molnar, Thomas Gleixner, x86-ml,
Borislav Petkov, linux-kernel
The following commit has been merged into the x86/build branch of tip:
Commit-ID: 66584ea6b70a6cbae661292702e56a07580dbbd4
Gitweb: https://git.kernel.org/tip/66584ea6b70a6cbae661292702e56a07580dbbd4
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
AuthorDate: Fri, 15 Nov 2019 00:49:22 +09:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Fri, 15 Nov 2019 12:07:32 +01:00
x86/build/vdso: Remove meaningless CFLAGS_REMOVE_*.o
CFLAGS_REMOVE_*.o syntax is used to drop particular flags when
building objects from C files. It has no effect for assembly files.
vdso-note.o is compiled from the assembly file, vdso-note.S, hence
CFLAGS_REMOVE_vdso-note.o is meaningless.
Neither vvar.c nor vvar.S is found in the vdso directory. Since there
is no source file to create vvar.o, CFLAGS_REMOVE_vvar.o is also
meaningless.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20191114154922.30365-1-yamada.masahiro@socionext.com
---
arch/x86/entry/vdso/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index 0f21541..2b75e80 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -87,11 +87,9 @@ $(vobjs): KBUILD_CFLAGS := $(filter-out $(GCC_PLUGINS_CFLAGS) $(RETPOLINE_CFLAGS
#
# vDSO code runs in userspace and -pg doesn't help with profiling anyway.
#
-CFLAGS_REMOVE_vdso-note.o = -pg
CFLAGS_REMOVE_vclock_gettime.o = -pg
CFLAGS_REMOVE_vdso32/vclock_gettime.o = -pg
CFLAGS_REMOVE_vgetcpu.o = -pg
-CFLAGS_REMOVE_vvar.o = -pg
#
# X32 processes use x32 vDSO to access 64bit kernel data.
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-15 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 15:49 [PATCH] x86/build/vdso: remove meaningless CFLAGS_REMOVE_*.o Masahiro Yamada
2019-11-15 11:51 ` [tip: x86/build] x86/build/vdso: Remove " tip-bot2 for Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).