* [PATCH] ASoC: rt5645: Fixed typo for buddy jack support.
@ 2019-11-14 19:08 Jacob Rasmussen
2019-11-14 21:43 ` Ross Zwisler
0 siblings, 1 reply; 4+ messages in thread
From: Jacob Rasmussen @ 2019-11-14 19:08 UTC (permalink / raw)
To: linux-kernel
Cc: Jacob Rasmussen, Bard Liao, Jaroslav Kysela, Liam Girdwood,
Mark Brown, Oder Chiou, Takashi Iwai, alsa-devel, zwisler,
stable
Had a typo in e7cfd867fd98 that resulted in buddy jack support not being
fixed.
Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.")
Cc: <zwisler@google.com>
Cc: <jacobraz@google.com>
CC: stable@vger.kernel.org
---
sound/soc/codecs/rt5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 902ac98a3fbe..19662ee330d6 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -3271,7 +3271,7 @@ static void rt5645_jack_detect_work(struct work_struct *work)
report, SND_JACK_MICROPHONE);
return;
case 4:
- val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x002;
+ val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x0020;
break;
default: /* read rt5645 jd1_1 status */
val = snd_soc_component_read32(rt5645->component, RT5645_INT_IRQ_ST) & 0x1000;
--
2.24.0.432.g9d3f5f5b63-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: rt5645: Fixed typo for buddy jack support.
2019-11-14 19:08 [PATCH] ASoC: rt5645: Fixed typo for buddy jack support Jacob Rasmussen
@ 2019-11-14 21:43 ` Ross Zwisler
2019-11-14 22:43 ` Jacob Rasmussen
0 siblings, 1 reply; 4+ messages in thread
From: Ross Zwisler @ 2019-11-14 21:43 UTC (permalink / raw)
To: Jacob Rasmussen
Cc: linux-kernel, Jacob Rasmussen, Bard Liao, Jaroslav Kysela,
Liam Girdwood, Mark Brown, Oder Chiou, Takashi Iwai, alsa-devel,
stable
On Thu, Nov 14, 2019 at 12:08:44PM -0700, Jacob Rasmussen wrote:
> Had a typo in e7cfd867fd98 that resulted in buddy jack support not being
> fixed.
>
> Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.")
> Cc: <zwisler@google.com>
> Cc: <jacobraz@google.com>
> CC: stable@vger.kernel.org
Need to add your signed-off-by. With that added you can add:
Reviewed-by: Ross Zwisler <zwisler@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: rt5645: Fixed typo for buddy jack support.
2019-11-14 21:43 ` Ross Zwisler
@ 2019-11-14 22:43 ` Jacob Rasmussen
2019-11-14 22:44 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Jacob Rasmussen @ 2019-11-14 22:43 UTC (permalink / raw)
To: Ross Zwisler
Cc: Jacob Rasmussen, linux-kernel, Bard Liao, Jaroslav Kysela,
Liam Girdwood, Mark Brown, Oder Chiou, Takashi Iwai, alsa-devel,
stable
On Thu, Nov 14, 2019 at 2:43 PM Ross Zwisler <zwisler@google.com> wrote:
>
> On Thu, Nov 14, 2019 at 12:08:44PM -0700, Jacob Rasmussen wrote:
> > Had a typo in e7cfd867fd98 that resulted in buddy jack support not being
> > fixed.
> >
> > Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.")
> > Cc: <zwisler@google.com>
> > Cc: <jacobraz@google.com>
> > CC: stable@vger.kernel.org
>
> Need to add your signed-off-by. With that added you can add:
>
> Reviewed-by: Ross Zwisler <zwisler@google.com>
Signed-off-by: Jacob Rasmussen <jacobraz@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: rt5645: Fixed typo for buddy jack support.
2019-11-14 22:43 ` Jacob Rasmussen
@ 2019-11-14 22:44 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-11-14 22:44 UTC (permalink / raw)
To: Jacob Rasmussen
Cc: Ross Zwisler, Jacob Rasmussen, linux-kernel, Bard Liao,
Jaroslav Kysela, Liam Girdwood, Oder Chiou, Takashi Iwai,
alsa-devel, stable
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Thu, Nov 14, 2019 at 03:43:32PM -0700, Jacob Rasmussen wrote:
> On Thu, Nov 14, 2019 at 2:43 PM Ross Zwisler <zwisler@google.com> wrote:
> > On Thu, Nov 14, 2019 at 12:08:44PM -0700, Jacob Rasmussen wrote:
> > > Had a typo in e7cfd867fd98 that resulted in buddy jack support not being
> > > fixed.
> > > Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.")
> > > Cc: <zwisler@google.com>
> > > Cc: <jacobraz@google.com>
> > > CC: stable@vger.kernel.org
> > Need to add your signed-off-by. With that added you can add:
> > Reviewed-by: Ross Zwisler <zwisler@google.com>
> Signed-off-by: Jacob Rasmussen <jacobraz@google.com>
I'd be more comfortable with this if you could repost with the signoff
and the patch in one mail.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-14 22:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 19:08 [PATCH] ASoC: rt5645: Fixed typo for buddy jack support Jacob Rasmussen
2019-11-14 21:43 ` Ross Zwisler
2019-11-14 22:43 ` Jacob Rasmussen
2019-11-14 22:44 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).