From: David Miller <davem@davemloft.net>
To: hslester96@gmail.com
Cc: hsweeten@visionengravers.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove
Date: Fri, 15 Nov 2019 12:42:55 -0800 (PST) [thread overview]
Message-ID: <20191115.124255.1583855143943561160.davem@davemloft.net> (raw)
In-Reply-To: <20191114154324.31990-1-hslester96@gmail.com>
From: Chuhong Yuan <hslester96@gmail.com>
Date: Thu, 14 Nov 2019 23:43:24 +0800
> The driver calls release_resource in remove to match request_mem_region
> in probe, which is incorrect.
> Fix it by using the right one, release_mem_region.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied, thanks.
It's a shame that you can't just pass in the thing you got back from
request_mem_region() to free it. And honestly the only thing that makes
calling release_region() wrong is that release_region() doesn't free up
the region object after unlinking it from the tree.
prev parent reply other threads:[~2019-11-15 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 15:43 [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove Chuhong Yuan
2019-11-15 20:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115.124255.1583855143943561160.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hslester96@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).