[PATCH] trace/synthetic_events: increase SYNTH_FIELDS_MAX

[PATCH] trace/synthetic_events: increase SYNTH_FIELDS_MAX

[Artem Bityutskiy]

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Increase the maximum allowed count of synthetic event fields from 16 to 32
in order to allow for larger-than-usual events.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 kernel/trace/trace_events_hist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 7482a1466ebf..f49d1a36d3ae 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -23,7 +23,7 @@
 #include "trace_dynevent.h"
 
 #define SYNTH_SYSTEM		"synthetic"
-#define SYNTH_FIELDS_MAX	16
+#define SYNTH_FIELDS_MAX	32
 
 #define STR_VAR_LEN_MAX		32 /* must be multiple of sizeof(u64) */
 
-- 
2.20.1

Re: [PATCH] trace/synthetic_events: increase SYNTH_FIELDS_MAX

[Steven Rostedt]

On Fri, 15 Nov 2019 11:17:30 +0200
Artem Bityutskiy <dedekind1@gmail.com> wrote:

> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> Increase the maximum allowed count of synthetic event fields from 16 to 32
> in order to allow for larger-than-usual events.

I'm fine with this, Tom are you OK with it?

-- Steve

> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> ---
>  kernel/trace/trace_events_hist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 7482a1466ebf..f49d1a36d3ae 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -23,7 +23,7 @@
>  #include "trace_dynevent.h"
>  
>  #define SYNTH_SYSTEM		"synthetic"
> -#define SYNTH_FIELDS_MAX	16
> +#define SYNTH_FIELDS_MAX	32
>  
>  #define STR_VAR_LEN_MAX		32 /* must be multiple of sizeof(u64) */
>  

Re: [PATCH] trace/synthetic_events: increase SYNTH_FIELDS_MAX

[Zanussi, Tom]

Hi Steve and Artem,

On 11/15/2019 9:52 AM, Steven Rostedt wrote:
> On Fri, 15 Nov 2019 11:17:30 +0200
> Artem Bityutskiy <dedekind1@gmail.com> wrote:
> 
>> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>>
>> Increase the maximum allowed count of synthetic event fields from 16 to 32
>> in order to allow for larger-than-usual events.
> 
> I'm fine with this, Tom are you OK with it?

Yeah, looks good to me.  Thanks for the patch, Artem.

Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Tom

> 
> -- Steve
> 
>>
>> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>> ---
>>   kernel/trace/trace_events_hist.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
>> index 7482a1466ebf..f49d1a36d3ae 100644
>> --- a/kernel/trace/trace_events_hist.c
>> +++ b/kernel/trace/trace_events_hist.c
>> @@ -23,7 +23,7 @@
>>   #include "trace_dynevent.h"
>>   
>>   #define SYNTH_SYSTEM		"synthetic"
>> -#define SYNTH_FIELDS_MAX	16
>> +#define SYNTH_FIELDS_MAX	32
>>   
>>   #define STR_VAR_LEN_MAX		32 /* must be multiple of sizeof(u64) */
>>   
>