linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v6 10/12] perf stat: Use affinity for reading
Date: Fri, 15 Nov 2019 15:55:28 +0100	[thread overview]
Message-ID: <20191115145528.GB4255@krava> (raw)
In-Reply-To: <20191112005941.649137-11-andi@firstfloor.org>

On Mon, Nov 11, 2019 at 04:59:39PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Restructure event reading to use affinity to minimize the number
> of IPIs needed.
> 
> Before on a large test case with 94 CPUs:
> 
> % time     seconds  usecs/call     calls    errors syscall
> ------ ----------- ----------- --------- --------- ----------------
>   3.16    0.106079           4     22082           read
> 
> After:
> 
>   3.43    0.081295           3     22082           read
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> ---
> 
> v2: Use new iterator macros
> v3: Use new iterator macros
> v4: Change iterator macros even more
> v5: Preserve counter->err in all cases
> ---
>  tools/perf/builtin-stat.c | 95 ++++++++++++++++++++++-----------------
>  tools/perf/util/evsel.h   |  1 +
>  2 files changed, 55 insertions(+), 41 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 039aefb07777..7784f5a93944 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -266,15 +266,10 @@ static int read_single_counter(struct evsel *counter, int cpu,
>   * Read out the results of a single counter:
>   * do not aggregate counts across CPUs in system-wide mode
>   */
> -static int read_counter(struct evsel *counter, struct timespec *rs)
> +static int read_counter(struct evsel *counter, struct timespec *rs, int cpu)

please rename this to read_counter_cpu

thanks,
jirka


  reply	other threads:[~2019-11-15 14:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  0:59 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-12  0:59 ` [PATCH v6 01/12] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-12  0:59 ` [PATCH v6 02/12] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-12  0:59 ` [PATCH v6 03/12] perf cpumap: Maintain cpumaps ordered and without dups Andi Kleen
2019-11-12  0:59 ` [PATCH v6 04/12] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-12  0:59 ` [PATCH v6 05/12] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-12  0:59 ` [PATCH v6 06/12] perf evsel: Add functions to close evsel on a CPU Andi Kleen
2019-11-12  0:59 ` [PATCH v6 07/12] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-12  0:59 ` [PATCH v6 08/12] perf stat: Factor out open error handling Andi Kleen
2019-11-12  0:59 ` [PATCH v6 09/12] perf stat: Use affinity for opening events Andi Kleen
2019-11-12  0:59 ` [PATCH v6 10/12] perf stat: Use affinity for reading Andi Kleen
2019-11-15 14:55   ` Jiri Olsa [this message]
2019-11-15 14:55   ` Jiri Olsa
2019-11-15 18:37     ` Andi Kleen
2019-11-15 14:55   ` Jiri Olsa
2019-11-12  0:59 ` [PATCH v6 11/12] perf evsel: Add functions to enable/disable for a specific CPU Andi Kleen
2019-11-15 14:55   ` Jiri Olsa
2019-11-12  0:59 ` [PATCH v6 12/12] perf stat: Use affinity for enabling/disabling events Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115145528.GB4255@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).