* [PATCH v2] Input: synaptics-rmi4 - add missed operations in remove
@ 2019-11-14 2:34 Chuhong Yuan
2019-11-15 19:34 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-14 2:34 UTC (permalink / raw)
Cc: Dmitry Torokhov, linux-input, linux-kernel, Chuhong Yuan
The driver forgets to destroy workqueue in remove like what
is done when probe fails.
Add a call to destroy_workqueue to fix it.
Since unregistration will wait for the work to finish, we do
not need to deal with work in remove.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Remove the calls of canceling delay and flushing workqueue.
- Modify the commit message.
drivers/input/rmi4/rmi_f54.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index 484ae1f97330..897105b9a98b 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -730,6 +730,7 @@ static void rmi_f54_remove(struct rmi_function *fn)
video_unregister_device(&f54->vdev);
v4l2_device_unregister(&f54->v4l2);
+ destroy_workqueue(f54->workqueue);
}
struct rmi_function_handler rmi_f54_handler = {
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Input: synaptics-rmi4 - add missed operations in remove
2019-11-14 2:34 [PATCH v2] Input: synaptics-rmi4 - add missed operations in remove Chuhong Yuan
@ 2019-11-15 19:34 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2019-11-15 19:34 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: linux-input, linux-kernel
On Thu, Nov 14, 2019 at 10:34:05AM +0800, Chuhong Yuan wrote:
> The driver forgets to destroy workqueue in remove like what
> is done when probe fails.
> Add a call to destroy_workqueue to fix it.
>
> Since unregistration will wait for the work to finish, we do
> not need to deal with work in remove.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied, thank you.
> ---
> Changes in v2:
> - Remove the calls of canceling delay and flushing workqueue.
> - Modify the commit message.
>
> drivers/input/rmi4/rmi_f54.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index 484ae1f97330..897105b9a98b 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -730,6 +730,7 @@ static void rmi_f54_remove(struct rmi_function *fn)
>
> video_unregister_device(&f54->vdev);
> v4l2_device_unregister(&f54->v4l2);
> + destroy_workqueue(f54->workqueue);
> }
>
> struct rmi_function_handler rmi_f54_handler = {
> --
> 2.23.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-15 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 2:34 [PATCH v2] Input: synaptics-rmi4 - add missed operations in remove Chuhong Yuan
2019-11-15 19:34 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).