* [PATCH] net: atm: Reduce the severity of logging in unlink_clip_vcc
@ 2019-11-17 20:28 Aditya Pakki
2019-11-19 1:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2019-11-17 20:28 UTC (permalink / raw)
To: pakki001
Cc: kjlu, David S. Miller, Ido Schimmel, Thomas Gleixner,
Greg Kroah-Hartman, David Ahern, netdev, linux-kernel
In case of errors in unlink_clip_vcc, the logging level is set to
pr_crit but failures in clip_setentry are handled by pr_err().
The patch changes the severity consistent across invocations.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
net/atm/clip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/atm/clip.c b/net/atm/clip.c
index a7972da7235d..294cb9efe3d3 100644
--- a/net/atm/clip.c
+++ b/net/atm/clip.c
@@ -89,7 +89,7 @@ static void unlink_clip_vcc(struct clip_vcc *clip_vcc)
struct clip_vcc **walk;
if (!entry) {
- pr_crit("!clip_vcc->entry (clip_vcc %p)\n", clip_vcc);
+ pr_err("!clip_vcc->entry (clip_vcc %p)\n", clip_vcc);
return;
}
netif_tx_lock_bh(entry->neigh->dev); /* block clip_start_xmit() */
@@ -109,10 +109,10 @@ static void unlink_clip_vcc(struct clip_vcc *clip_vcc)
error = neigh_update(entry->neigh, NULL, NUD_NONE,
NEIGH_UPDATE_F_ADMIN, 0);
if (error)
- pr_crit("neigh_update failed with %d\n", error);
+ pr_err("neigh_update failed with %d\n", error);
goto out;
}
- pr_crit("ATMARP: failed (entry %p, vcc 0x%p)\n", entry, clip_vcc);
+ pr_err("ATMARP: failed (entry %p, vcc 0x%p)\n", entry, clip_vcc);
out:
netif_tx_unlock_bh(entry->neigh->dev);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: atm: Reduce the severity of logging in unlink_clip_vcc
2019-11-17 20:28 [PATCH] net: atm: Reduce the severity of logging in unlink_clip_vcc Aditya Pakki
@ 2019-11-19 1:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-19 1:08 UTC (permalink / raw)
To: pakki001; +Cc: kjlu, idosch, tglx, gregkh, dsahern, netdev, linux-kernel
From: Aditya Pakki <pakki001@umn.edu>
Date: Sun, 17 Nov 2019 14:28:36 -0600
> In case of errors in unlink_clip_vcc, the logging level is set to
> pr_crit but failures in clip_setentry are handled by pr_err().
> The patch changes the severity consistent across invocations.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-19 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-17 20:28 [PATCH] net: atm: Reduce the severity of logging in unlink_clip_vcc Aditya Pakki
2019-11-19 1:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).