Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check

Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check

[Greg KH]

On Mon, Nov 18, 2019 at 09:24:32AM +0000, David Binderman wrote:
> Hello there,
> 
> linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735:5: style: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
> 
> Source code is
> 
>     if (tpm_suspend_pcr)
>         rc = tpm1_pcr_extend(chip, tpm_suspend_pcr, dummy_hash,
>                      "extending dummy pcr before suspend");
> 
>     rc = tpm_buf_init(&buf, TPM_TAG_RQU_COMMAND, TPM_ORD_SAVESTATE);
> 
> Suggest add test of rc after call to tpm1_pcr_extend.

Great, how about you submit a patch to resolve this?  That way you can
get the full credit for finding and resolveing the issue?

thanks,

greg k-h

Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check

[Greg KH]

On Mon, Nov 18, 2019 at 09:42:01AM +0000, David Binderman wrote:
> Hello there Greg,
> 
> >Great, how about you submit a patch to resolve this?  That way you can
> >get the full credit for finding and resolveing the issue?
> 
> No thanks. I gave up bothering to send in patches when I found
> out my emails cc'ing to the linux kernel mailing list get bounced.

Yes, hotmail.com emails have been rejected from there for many years.
If you wish to contribute to the kernel you need to use a different
email domain, sorry.

good luck!

greg k-h

Re: linux-5.4-rc8/drivers/char/tpm/tpm1-cmd.c:735: possible missing return value check

[Jarkko Sakkinen]

On Mon, Nov 18, 2019 at 09:42:01AM +0000, David Binderman wrote:
> Hello there Greg,
> 
> >Great, how about you submit a patch to resolve this?  That way you can
> >get the full credit for finding and resolveing the issue?
> 
> No thanks. I gave up bothering to send in patches when I found
> out my emails cc'ing to the linux kernel mailing list get bounced.
> I am happy for someone else to invent a patch.
> 
> BTW, more of the same here:
> 
> linux-5.4-rc8/drivers/char/tpm/tpm_infineon.c:173:10: style: Variable 'status' is reassigned a value before the old one has been used. [redundantAssignment]
> 
> 
> Regards
> 
> David

I'm fine with adding reported-by from you unless you want to send a fix.

I'll create a fix after 5.5-rc1 is out.

/Jarkko