* [PATCH 0/2] coresight: next v5.4-rc8
@ 2019-11-18 18:52 Mathieu Poirier
2019-11-18 18:52 ` [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init() Mathieu Poirier
2019-11-18 18:52 ` [PATCH 2/2] coresight: replicator: " Mathieu Poirier
0 siblings, 2 replies; 5+ messages in thread
From: Mathieu Poirier @ 2019-11-18 18:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-arm-kernel, linux-kernel
Good morning,
Since we have an rc8 and the fix are trivial, please consider for the next
merge window.
Thanks,
Mathieu
Wei Yongjun (2):
coresight: funnel: Fix missing spin_lock_init()
coresight: replicator: Fix missing spin_lock_init()
drivers/hwtracing/coresight/coresight-funnel.c | 1 +
drivers/hwtracing/coresight/coresight-replicator.c | 1 +
2 files changed, 2 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init()
2019-11-18 18:52 [PATCH 0/2] coresight: next v5.4-rc8 Mathieu Poirier
@ 2019-11-18 18:52 ` Mathieu Poirier
2019-11-19 4:30 ` Greg KH
2019-11-18 18:52 ` [PATCH 2/2] coresight: replicator: " Mathieu Poirier
1 sibling, 1 reply; 5+ messages in thread
From: Mathieu Poirier @ 2019-11-18 18:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-arm-kernel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.
This is detected by Coccinelle semantic patch.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Tested-by: Yabin Cui <yabinc@google.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/hwtracing/coresight/coresight-funnel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
index b605889b507a..900690a9f7f0 100644
--- a/drivers/hwtracing/coresight/coresight-funnel.c
+++ b/drivers/hwtracing/coresight/coresight-funnel.c
@@ -253,6 +253,7 @@ static int funnel_probe(struct device *dev, struct resource *res)
}
dev->platform_data = pdata;
+ spin_lock_init(&drvdata->spinlock);
desc.type = CORESIGHT_DEV_TYPE_LINK;
desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_MERG;
desc.ops = &funnel_cs_ops;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] coresight: replicator: Fix missing spin_lock_init()
2019-11-18 18:52 [PATCH 0/2] coresight: next v5.4-rc8 Mathieu Poirier
2019-11-18 18:52 ` [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init() Mathieu Poirier
@ 2019-11-18 18:52 ` Mathieu Poirier
1 sibling, 0 replies; 5+ messages in thread
From: Mathieu Poirier @ 2019-11-18 18:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-arm-kernel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.
This is detected by Coccinelle semantic patch.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Tested-by: Yabin Cui <yabinc@google.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/hwtracing/coresight/coresight-replicator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 43304196a1a6..e7dc1c31d20d 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -248,6 +248,7 @@ static int replicator_probe(struct device *dev, struct resource *res)
}
dev->platform_data = pdata;
+ spin_lock_init(&drvdata->spinlock);
desc.type = CORESIGHT_DEV_TYPE_LINK;
desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_SPLIT;
desc.ops = &replicator_cs_ops;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init()
2019-11-18 18:52 ` [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init() Mathieu Poirier
@ 2019-11-19 4:30 ` Greg KH
2019-11-19 16:15 ` Mathieu Poirier
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-11-19 4:30 UTC (permalink / raw)
To: Mathieu Poirier; +Cc: linux-arm-kernel, linux-kernel
On Mon, Nov 18, 2019 at 11:52:06AM -0700, Mathieu Poirier wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The driver allocates the spinlock but not initialize it.
> Use spin_lock_init() on it to initialize it correctly.
>
> This is detected by Coccinelle semantic patch.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Tested-by: Yabin Cui <yabinc@google.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-funnel.c | 1 +
> 1 file changed, 1 insertion(+)
Is this, and the 2/2 patch here, needed for stable releases?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init()
2019-11-19 4:30 ` Greg KH
@ 2019-11-19 16:15 ` Mathieu Poirier
0 siblings, 0 replies; 5+ messages in thread
From: Mathieu Poirier @ 2019-11-19 16:15 UTC (permalink / raw)
To: Greg KH; +Cc: linux-arm-kernel, Linux Kernel Mailing List
On Mon, 18 Nov 2019 at 21:30, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Nov 18, 2019 at 11:52:06AM -0700, Mathieu Poirier wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > The driver allocates the spinlock but not initialize it.
> > Use spin_lock_init() on it to initialize it correctly.
> >
> > This is detected by Coccinelle semantic patch.
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > Tested-by: Yabin Cui <yabinc@google.com>
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > ---
> > drivers/hwtracing/coresight/coresight-funnel.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Is this, and the 2/2 patch here, needed for stable releases?
No as the code they fix is new to this cycle[1].
Thanks for being inquisitive,
Mathieu
[1]. https://lkml.org/lkml/2019/11/4/726
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-19 16:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 18:52 [PATCH 0/2] coresight: next v5.4-rc8 Mathieu Poirier
2019-11-18 18:52 ` [PATCH 1/2] coresight: funnel: Fix missing spin_lock_init() Mathieu Poirier
2019-11-19 4:30 ` Greg KH
2019-11-19 16:15 ` Mathieu Poirier
2019-11-18 18:52 ` [PATCH 2/2] coresight: replicator: " Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).