* [PATCH] staging: octeon: indent with tabs instead of spaces
@ 2019-11-18 18:38 Giovanni Gherdovich
2019-11-18 19:01 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Giovanni Gherdovich @ 2019-11-18 18:38 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Aaro Koskinen, devel, linux-kernel, Giovanni Gherdovich
Remove a coding style error from the Octeon driver's tree and keep
checkpatch.pl a little quieter.
Being a white-spaces patch the chances of breakage are minimal; we don't
have the hardware to run this driver so we built it with COMPILE_TEST
enabled on an x86 machine.
Signed-off-by: Giovanni Gherdovich <bobdc9664@seznam.cz>
---
drivers/staging/octeon/octeon-stubs.h | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index ed9d44ff148b..79213c045504 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1140,22 +1140,22 @@ union cvmx_npi_rsl_int_blocks {
union cvmx_pko_command_word0 {
uint64_t u64;
struct {
- uint64_t total_bytes:16;
- uint64_t segs:6;
- uint64_t dontfree:1;
- uint64_t ignore_i:1;
- uint64_t ipoffp1:7;
- uint64_t gather:1;
- uint64_t rsp:1;
- uint64_t wqp:1;
- uint64_t n2:1;
- uint64_t le:1;
- uint64_t reg0:11;
- uint64_t subone0:1;
- uint64_t reg1:11;
- uint64_t subone1:1;
- uint64_t size0:2;
- uint64_t size1:2;
+ uint64_t total_bytes:16;
+ uint64_t segs:6;
+ uint64_t dontfree:1;
+ uint64_t ignore_i:1;
+ uint64_t ipoffp1:7;
+ uint64_t gather:1;
+ uint64_t rsp:1;
+ uint64_t wqp:1;
+ uint64_t n2:1;
+ uint64_t le:1;
+ uint64_t reg0:11;
+ uint64_t subone0:1;
+ uint64_t reg1:11;
+ uint64_t subone1:1;
+ uint64_t size0:2;
+ uint64_t size1:2;
} s;
};
--
2.16.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: octeon: indent with tabs instead of spaces
2019-11-18 18:38 [PATCH] staging: octeon: indent with tabs instead of spaces Giovanni Gherdovich
@ 2019-11-18 19:01 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2019-11-18 19:01 UTC (permalink / raw)
To: Giovanni Gherdovich
Cc: Greg Kroah-Hartman, devel, linux-kernel, Aaro Koskinen
On Mon, Nov 18, 2019 at 07:38:52PM +0100, Giovanni Gherdovich wrote:
> Remove a coding style error from the Octeon driver's tree and keep
> checkpatch.pl a little quieter.
>
> Being a white-spaces patch the chances of breakage are minimal; we don't
> have the hardware to run this driver so we built it with COMPILE_TEST
> enabled on an x86 machine.
Next time put this sort of comment under the --- cut off line so that we
sound like we're bursting with confidence in the permanent git log. ;)
>
> Signed-off-by: Giovanni Gherdovich <bobdc9664@seznam.cz>
> ---
^^^
> drivers/staging/octeon/octeon-stubs.h | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
Anyway, looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: octeon: Indent with tabs instead of spaces
2020-07-22 17:19 [PATCH] staging: octeon: Indent " Muhammad Usama Anjum
2020-07-22 19:56 ` Joe Perches
@ 2020-07-24 10:45 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2020-07-24 10:45 UTC (permalink / raw)
To: Muhammad Usama Anjum; +Cc: gregkh, devel, linux-kernel
On Wed, Jul 22, 2020 at 10:19:50PM +0500, Muhammad Usama Anjum wrote:
> Remove a coding style error. It makes code more readable.
>
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
> ---
This isn't a part of the official style guide so the original is fine.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: octeon: Indent with tabs instead of spaces
2020-07-22 17:19 [PATCH] staging: octeon: Indent " Muhammad Usama Anjum
@ 2020-07-22 19:56 ` Joe Perches
2020-07-24 10:45 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Joe Perches @ 2020-07-22 19:56 UTC (permalink / raw)
To: Muhammad Usama Anjum, gregkh, devel, linux-kernel
On Wed, 2020-07-22 at 22:19 +0500, Muhammad Usama Anjum wrote:
> Remove a coding style error. It makes code more readable.
[]
> diff --git a/drivers/staging/octeon/ethernet-defines.h b/drivers/staging/octeon/ethernet-defines.h
[]
> @@ -27,14 +27,14 @@
> #define REUSE_SKBUFFS_WITHOUT_FREE 1
> #endif
>
> -#define USE_ASYNC_IOBDMA (CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE > 0)
> +#define USE_ASYNC_IOBDMA (CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE > 0)
>
> /* Maximum number of SKBs to try to free per xmit packet. */
> -#define MAX_OUT_QUEUE_DEPTH 1000
> +#define MAX_OUT_QUEUE_DEPTH 1000
>
> #define FAU_TOTAL_TX_TO_CLEAN (CVMX_FAU_REG_END - sizeof(u32))
If you really like alignment to tabstop,
why not align FAU_TOTAL_TX_TO_CLEAN too?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: octeon: Indent with tabs instead of spaces
@ 2020-07-22 17:19 Muhammad Usama Anjum
2020-07-22 19:56 ` Joe Perches
2020-07-24 10:45 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2020-07-22 17:19 UTC (permalink / raw)
To: gregkh, devel, linux-kernel
Remove a coding style error. It makes code more readable.
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
---
drivers/staging/octeon/ethernet-defines.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-defines.h b/drivers/staging/octeon/ethernet-defines.h
index ef9e767b0e2e..40f91c78e462 100644
--- a/drivers/staging/octeon/ethernet-defines.h
+++ b/drivers/staging/octeon/ethernet-defines.h
@@ -27,14 +27,14 @@
#define REUSE_SKBUFFS_WITHOUT_FREE 1
#endif
-#define USE_ASYNC_IOBDMA (CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE > 0)
+#define USE_ASYNC_IOBDMA (CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE > 0)
/* Maximum number of SKBs to try to free per xmit packet. */
-#define MAX_OUT_QUEUE_DEPTH 1000
+#define MAX_OUT_QUEUE_DEPTH 1000
#define FAU_TOTAL_TX_TO_CLEAN (CVMX_FAU_REG_END - sizeof(u32))
#define FAU_NUM_PACKET_BUFFERS_TO_FREE (FAU_TOTAL_TX_TO_CLEAN - sizeof(u32))
-#define TOTAL_NUMBER_OF_PORTS (CVMX_PIP_NUM_INPUT_PORTS + 1)
+#define TOTAL_NUMBER_OF_PORTS (CVMX_PIP_NUM_INPUT_PORTS + 1)
#endif /* __ETHERNET_DEFINES_H__ */
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-24 10:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 18:38 [PATCH] staging: octeon: indent with tabs instead of spaces Giovanni Gherdovich
2019-11-18 19:01 ` Dan Carpenter
2020-07-22 17:19 [PATCH] staging: octeon: Indent " Muhammad Usama Anjum
2020-07-22 19:56 ` Joe Perches
2020-07-24 10:45 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).