* [PATCH -next] vsock/vmci: make vmci_vsock_cb_host_called static
@ 2019-11-19 3:25 Mao Wenan
2019-11-19 8:11 ` Stefano Garzarella
0 siblings, 1 reply; 2+ messages in thread
From: Mao Wenan @ 2019-11-19 3:25 UTC (permalink / raw)
To: arnd, gregkh, davem, sgarzare, kstewart, alexios.zavras, tglx, maowenan
Cc: linux-kernel, kernel-janitors, Hulk Robot
When using make C=2 drivers/misc/vmw_vmci/vmci_driver.o
to compile, below warning can be seen:
drivers/misc/vmw_vmci/vmci_driver.c:33:6: warning:
symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?
This patch make symbol vmci_vsock_cb_host_called static.
Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/misc/vmw_vmci/vmci_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
index 95fed46..cbb706d 100644
--- a/drivers/misc/vmw_vmci/vmci_driver.c
+++ b/drivers/misc/vmw_vmci/vmci_driver.c
@@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;
static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
static vmci_vsock_cb vmci_vsock_transport_cb;
-bool vmci_vsock_cb_host_called;
+static bool vmci_vsock_cb_host_called;
/*
* vmci_get_context_id() - Gets the current context ID.
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] vsock/vmci: make vmci_vsock_cb_host_called static
2019-11-19 3:25 [PATCH -next] vsock/vmci: make vmci_vsock_cb_host_called static Mao Wenan
@ 2019-11-19 8:11 ` Stefano Garzarella
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Garzarella @ 2019-11-19 8:11 UTC (permalink / raw)
To: Mao Wenan, netdev, davem
Cc: arnd, gregkh, kstewart, alexios.zavras, tglx, linux-kernel,
kernel-janitors, Hulk Robot
On Tue, Nov 19, 2019 at 11:25:34AM +0800, Mao Wenan wrote:
> When using make C=2 drivers/misc/vmw_vmci/vmci_driver.o
> to compile, below warning can be seen:
> drivers/misc/vmw_vmci/vmci_driver.c:33:6: warning:
> symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?
>
> This patch make symbol vmci_vsock_cb_host_called static.
>
> Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/misc/vmw_vmci/vmci_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
> index 95fed46..cbb706d 100644
> --- a/drivers/misc/vmw_vmci/vmci_driver.c
> +++ b/drivers/misc/vmw_vmci/vmci_driver.c
> @@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;
>
> static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
> static vmci_vsock_cb vmci_vsock_transport_cb;
> -bool vmci_vsock_cb_host_called;
> +static bool vmci_vsock_cb_host_called;
>
> /*
> * vmci_get_context_id() - Gets the current context ID.
> --
> 2.7.4
>
Same patch already sent by "kbuild test robot" <lkp@intel.com>
https://lkml.org/lkml/2019/11/18/609
If we want to merge this, maybe we can also add:
Reported-by: kbuild test robot <lkp@intel.com>
Anyway, it is my fault:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-19 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 3:25 [PATCH -next] vsock/vmci: make vmci_vsock_cb_host_called static Mao Wenan
2019-11-19 8:11 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).