[PATCH] regmap: regmap-w1: Drop unreachable code

[PATCH] regmap: regmap-w1: Drop unreachable code

[Mika Westerberg]

Both init functions have a stray "return NULL" at the end which is never
reached so drop them.

Fixes: cc5d0db390b0 ("regmap: Add 1-Wire bus support")
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/base/regmap/regmap-w1.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/base/regmap/regmap-w1.c b/drivers/base/regmap/regmap-w1.c
index 3a7d30b8c3ac..1fbaaad71ca5 100644
--- a/drivers/base/regmap/regmap-w1.c
+++ b/drivers/base/regmap/regmap-w1.c
@@ -215,8 +215,6 @@ struct regmap *__regmap_init_w1(struct device *w1_dev,
 
 	return __regmap_init(w1_dev, bus, w1_dev, config,
 			 lock_key, lock_name);
-
-	return NULL;
 }
 EXPORT_SYMBOL_GPL(__regmap_init_w1);
 
@@ -233,8 +231,6 @@ struct regmap *__devm_regmap_init_w1(struct device *w1_dev,
 
 	return __devm_regmap_init(w1_dev, bus, w1_dev, config,
 				 lock_key, lock_name);
-
-	return NULL;
 }
 EXPORT_SYMBOL_GPL(__devm_regmap_init_w1);
 
-- 
2.24.0

Re: [PATCH] regmap: regmap-w1: Drop unreachable code

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

On Tue, Nov 19, 2019 at 03:58:37PM +0300, Mika Westerberg wrote:
> Both init functions have a stray "return NULL" at the end which is never
> reached so drop them.
> 
> Fixes: cc5d0db390b0 ("regmap: Add 1-Wire bus support")

You're overusing the Fixes tag here...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]