From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 09/12] perf stat: Use affinity for opening events
Date: Wed, 20 Nov 2019 14:31:01 -0800 [thread overview]
Message-ID: <20191120223101.GB84886@tassilo.jf.intel.com> (raw)
In-Reply-To: <20191120150732.GE4007@krava>
> > + evlist__for_each_cpu (evsel_list, i, cpu) {
> > + affinity__set(&affinity, cpu);
> > + /* First close errored or weak retry */
> > + evlist__for_each_entry(evsel_list, counter) {
> > + if (!counter->reset_group && !counter->errored)
> > + continue;
> > + if (evsel__cpu_iter_skip_no_inc(counter, cpu))
> > + continue;
> > + perf_evsel__close_cpu(&counter->core, counter->cpu_iter);
> > + }
> > + /* Now reopen weak */
> > + evlist__for_each_entry(evsel_list, counter) {
> > + if (!counter->reset_group && !counter->errored)
> > + continue;
> > + if (evsel__cpu_iter_skip(counter, cpu))
> > + continue;
>
> why staring at this I wonder why can't we call perf_evsel__close_cpu in
> here and remove the above loop? together with evsel__cpu_iter_skip_no_inc
> function
We only want to close events which errored or need a weak entry.
The others can stay open. perf_evsel__close_cpu closes all unconditionally.
-Andi
next prev parent reply other threads:[~2019-11-20 22:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 5:52 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-16 5:52 ` [PATCH v7 01/12] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-16 5:52 ` [PATCH v7 02/12] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-16 5:52 ` [PATCH v7 03/12] perf cpumap: Maintain cpumaps ordered and without dups Andi Kleen
2019-11-16 5:52 ` [PATCH v7 04/12] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-16 5:52 ` [PATCH v7 05/12] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-16 5:52 ` [PATCH v7 06/12] perf evsel: Add functions to close evsel on a CPU Andi Kleen
2019-11-16 5:52 ` [PATCH v7 07/12] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-16 5:52 ` [PATCH v7 08/12] perf stat: Factor out open error handling Andi Kleen
2019-11-16 5:52 ` [PATCH v7 09/12] perf stat: Use affinity for opening events Andi Kleen
2019-11-20 15:07 ` Jiri Olsa
2019-11-20 22:31 ` Andi Kleen [this message]
2019-11-21 15:13 ` Jiri Olsa
2019-11-16 5:52 ` [PATCH v7 10/12] perf stat: Use affinity for reading Andi Kleen
2019-11-20 15:12 ` Jiri Olsa
2019-11-16 5:52 ` [PATCH v7 11/12] perf evsel: Add functions to enable/disable for a specific CPU Andi Kleen
2019-11-16 5:52 ` [PATCH v7 12/12] perf stat: Use affinity for enabling/disabling events Andi Kleen
2019-11-20 15:16 ` Optimize perf stat for large number of events/cpus Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120223101.GB84886@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).