* [PATCH -next] enetc: make enetc_setup_tc_mqprio static
@ 2019-11-22 2:52 Mao Wenan
2019-11-22 3:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mao Wenan @ 2019-11-22 2:52 UTC (permalink / raw)
To: claudiu.manoil, davem, vladimir.oltean, po.liu
Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan
While using ARCH=mips CROSS_COMPILE=mips-linux-gnu- command to compile,
make C=2 drivers/net/ethernet/freescale/enetc/enetc.o
one warning can be found:
drivers/net/ethernet/freescale/enetc/enetc.c:1439:5:
warning: symbol 'enetc_setup_tc_mqprio' was not declared.
Should it be static?
This patch make symbol enetc_setup_tc_mqprio static.
Fixes: 34c6adf1977b ("enetc: Configure the Time-Aware Scheduler via tc-taprio offload")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/net/ethernet/freescale/enetc/enetc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index f6b00c6..27f6fd1 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -1436,7 +1436,7 @@ int enetc_close(struct net_device *ndev)
return 0;
}
-int enetc_setup_tc_mqprio(struct net_device *ndev, void *type_data)
+static int enetc_setup_tc_mqprio(struct net_device *ndev, void *type_data)
{
struct enetc_ndev_priv *priv = netdev_priv(ndev);
struct tc_mqprio_qopt *mqprio = type_data;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] enetc: make enetc_setup_tc_mqprio static
2019-11-22 2:52 [PATCH -next] enetc: make enetc_setup_tc_mqprio static Mao Wenan
@ 2019-11-22 3:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-22 3:30 UTC (permalink / raw)
To: maowenan
Cc: claudiu.manoil, vladimir.oltean, po.liu, netdev, linux-kernel,
kernel-janitors
From: Mao Wenan <maowenan@huawei.com>
Date: Fri, 22 Nov 2019 10:52:40 +0800
> While using ARCH=mips CROSS_COMPILE=mips-linux-gnu- command to compile,
> make C=2 drivers/net/ethernet/freescale/enetc/enetc.o
>
> one warning can be found:
> drivers/net/ethernet/freescale/enetc/enetc.c:1439:5:
> warning: symbol 'enetc_setup_tc_mqprio' was not declared.
> Should it be static?
>
> This patch make symbol enetc_setup_tc_mqprio static.
> Fixes: 34c6adf1977b ("enetc: Configure the Time-Aware Scheduler via tc-taprio offload")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-22 3:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 2:52 [PATCH -next] enetc: make enetc_setup_tc_mqprio static Mao Wenan
2019-11-22 3:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).