From: Pete Zaitcev <zaitcev@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: syzbot <syzbot+56f9673bb4cdcbeb0e92@syzkaller.appspotmail.com>,
<arnd@arndb.de>, <gregkh@linuxfoundation.org>,
<jrdr.linux@gmail.com>, <keescook@chromium.org>,
<kstewart@linuxfoundation.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
<syzkaller-bugs@googlegroups.com>, <tglx@linutronix.de>,
<viro@zeniv.linux.org.uk>,
zaitcev@redhat.com
Subject: Re: possible deadlock in mon_bin_vma_fault
Date: Thu, 21 Nov 2019 10:46:51 -0600 [thread overview]
Message-ID: <20191121104651.0d50d2bd@suzdal.zaitcev.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1911211118450.1553-100000@iolanthe.rowland.org>
On Thu, 21 Nov 2019 11:20:20 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:
> On Thu, 21 Nov 2019, Pete Zaitcev wrote:
>
> > Anyway... If you are looking at it too, what do you think about not using
> > any locks in mon_bin_vma_fault() at all? Isn't it valid? I think I tried
> > to be "safe", but it only uses things that are constants unless we're
> > opening and closing; a process cannot make page faults unless it has
> > some thing mapped; and that is only possible if device is open and stays
> > open. Can you find a hole in this reasoning?
>
> I think you're right. But one thing concerns me: What happens if the
> same buffer is mapped by more than one process? Do you allow that?
Yes, we allow 2 processes reading from mmap in the same time.
They may miss events, but there should be no issue to the internal
consistency of any pointers in usbmon, and no crashes or deadlocks.
Also, we cannot prohibit that. Imagine a process that does open(),
mmap(), fork()/clone().
-- Pete
next prev parent reply other threads:[~2019-11-21 16:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 22:01 possible deadlock in mon_bin_vma_fault syzbot
2019-11-20 12:01 ` syzbot
2019-11-20 16:14 ` Alan Stern
2019-11-20 17:12 ` Pete Zaitcev
2019-11-20 18:47 ` Alan Stern
2019-11-21 14:48 ` Pete Zaitcev
2019-11-21 16:20 ` Alan Stern
2019-11-21 16:46 ` Pete Zaitcev [this message]
2019-11-21 23:38 ` Pete Zaitcev
2019-11-22 7:18 ` Dmitry Vyukov
2019-11-22 15:27 ` Alan Stern
2019-11-22 20:52 ` Pete Zaitcev
2019-11-22 22:13 ` Alan Stern
2019-11-22 22:13 ` syzbot
2019-11-23 17:18 ` Alan Stern
2019-11-23 17:18 ` syzbot
2019-11-24 15:59 ` Alan Stern
2019-11-24 19:10 ` syzbot
2019-11-24 20:55 ` Alan Stern
2019-11-24 23:24 ` syzbot
2019-11-25 0:10 ` Pete Zaitcev
2019-11-25 2:12 ` Alan Stern
2019-11-23 17:18 ` Re: " syzbot
2019-11-22 22:13 ` syzbot
2019-11-20 17:33 ` Pete Zaitcev
2019-11-20 18:18 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121104651.0d50d2bd@suzdal.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+56f9673bb4cdcbeb0e92@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).