From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Philipp Zabel <pza@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [PATCH v8 3/6] pwm: sun4i: Add an optional probe for bus clock
Date: Thu, 21 Nov 2019 22:05:59 +0100 [thread overview]
Message-ID: <20191121210559.pz3nsyomqfrjuoe4@pengutronix.de> (raw)
In-Reply-To: <20191121195902.6906-4-peron.clem@gmail.com>
On Thu, Nov 21, 2019 at 08:58:59PM +0100, Clément Péron wrote:
> From: Jernej Skrabec <jernej.skrabec@siol.net>
>
> H6 PWM core needs bus clock to be enabled in order to work.
>
> Add an optional probe for it.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> drivers/pwm/pwm-sun4i.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
> index 369990ae7d09..66befd8d6f9c 100644
> --- a/drivers/pwm/pwm-sun4i.c
> +++ b/drivers/pwm/pwm-sun4i.c
> @@ -78,6 +78,7 @@ struct sun4i_pwm_data {
>
> struct sun4i_pwm_chip {
> struct pwm_chip chip;
> + struct clk *bus_clk;
> struct clk *clk;
> struct reset_control *rst;
> void __iomem *base;
> @@ -391,6 +392,14 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
> }
> }
>
> + pwm->bus_clk = devm_clk_get_optional(&pdev->dev, "bus");
> + if (IS_ERR(pwm->bus_clk)) {
> + if (PTR_ERR(pwm->rst) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "get bus clock failed %pe\n",
> + pwm->bus_clk);
> + return PTR_ERR(pwm->bus_clk);
> + }
> +
> pwm->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
> if (IS_ERR(pwm->rst)) {
> if (PTR_ERR(pwm->rst) != -EPROBE_DEFER)
> @@ -407,6 +416,17 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
> return ret;
> }
>
> + /*
> + * We're keeping the bus clock on for the sake of simplicity.
> + * Actually it only needs to be on for hardware register accesses.
> + */
> + ret = clk_prepare_enable(pwm->bus_clk);
> + if (ret) {
> + dev_err(&pdev->dev, "Cannot prepare and enable bus_clk %d\n",
> + ret);
nitpick: other error messages in this driver start with a lower case
letter.
Until there is an equivalent for %pe that consumes an int, I suggest to
use
dev_err(&pdev->dev, "Cannot prepare and enable bus_clk: %pe\n",
ERR_PTR(ret));
to benefit from a symbolic error name instead of an error constant.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-11-21 21:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 19:58 [PATCH v8 0/6] Add support for H6 PWM Clément Péron
2019-11-21 19:58 ` [PATCH v8 1/6] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-21 19:58 ` [PATCH v8 2/6] pwm: sun4i: Prefer "mod" clock to unnamed Clément Péron
2019-11-21 19:58 ` [PATCH v8 3/6] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-21 21:05 ` Uwe Kleine-König [this message]
2019-11-21 21:31 ` Clément Péron
2019-11-21 19:59 ` [PATCH v8 4/6] pwm: sun4i: Always calculate params when applying new parameters Clément Péron
2019-11-21 21:11 ` Uwe Kleine-König
2019-11-21 19:59 ` [PATCH v8 5/6] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-21 21:16 ` Uwe Kleine-König
2019-11-21 21:21 ` Clément Péron
2019-11-23 14:05 ` Clément Péron
2019-11-23 20:00 ` Uwe Kleine-König
2019-11-21 19:59 ` [PATCH v8 6/6] pwm: sun4i: Add support for H6 PWM Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121210559.pz3nsyomqfrjuoe4@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=pza@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).