From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Philipp Zabel <pza@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
kernel@pengutronix.de
Subject: Re: [PATCH v8 4/6] pwm: sun4i: Always calculate params when applying new parameters
Date: Thu, 21 Nov 2019 22:11:43 +0100 [thread overview]
Message-ID: <20191121211142.kuhcxpxudt3tod4p@pengutronix.de> (raw)
In-Reply-To: <20191121195902.6906-5-peron.clem@gmail.com>
On Thu, Nov 21, 2019 at 08:59:00PM +0100, Clément Péron wrote:
> Bypass mode will require to be re-calculated when the pwm state
> is changed.
>
> Remove the condition so pwm_sun4i_calculate is always called.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
When applying this patch and looking at it using git show -b it is
obvious the patch does exactly what is promised here. (Apart from the
introduced empty line in the last hunk which is ok in my book.)
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-11-21 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 19:58 [PATCH v8 0/6] Add support for H6 PWM Clément Péron
2019-11-21 19:58 ` [PATCH v8 1/6] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-21 19:58 ` [PATCH v8 2/6] pwm: sun4i: Prefer "mod" clock to unnamed Clément Péron
2019-11-21 19:58 ` [PATCH v8 3/6] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-21 21:05 ` Uwe Kleine-König
2019-11-21 21:31 ` Clément Péron
2019-11-21 19:59 ` [PATCH v8 4/6] pwm: sun4i: Always calculate params when applying new parameters Clément Péron
2019-11-21 21:11 ` Uwe Kleine-König [this message]
2019-11-21 19:59 ` [PATCH v8 5/6] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-21 21:16 ` Uwe Kleine-König
2019-11-21 21:21 ` Clément Péron
2019-11-23 14:05 ` Clément Péron
2019-11-23 20:00 ` Uwe Kleine-König
2019-11-21 19:59 ` [PATCH v8 6/6] pwm: sun4i: Add support for H6 PWM Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121211142.kuhcxpxudt3tod4p@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=pza@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).