From: David Miller <davem@davemloft.net>
To: chenwandun@huawei.com
Cc: vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings
Date: Fri, 22 Nov 2019 10:09:52 -0800 (PST) [thread overview]
Message-ID: <20191122.100952.137407515946118851.davem@davemloft.net> (raw)
In-Reply-To: <1574425965-97890-1-git-send-email-chenwandun@huawei.com>
From: Chen Wandun <chenwandun@huawei.com>
Date: Fri, 22 Nov 2019 20:32:45 +0800
> Fix following sparse warnings:
> drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?
>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Next time please indicate _explicitly_ which tree your patch is targetting,
because especially in this case the change is only relevant for "net-next"
Also, please provide a proper Fixes: tag.
prev parent reply other threads:[~2019-11-22 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 12:32 [PATCH] net: dsa: ocelot: fix "should it be static?" warnings Chen Wandun
2019-11-22 15:32 ` Vivien Didelot
2019-11-22 18:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122.100952.137407515946118851.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=chenwandun@huawei.com \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).