* [PATCH] net: dsa: ocelot: fix "should it be static?" warnings
@ 2019-11-22 12:32 Chen Wandun
2019-11-22 15:32 ` Vivien Didelot
2019-11-22 18:09 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Chen Wandun @ 2019-11-22 12:32 UTC (permalink / raw)
To: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
f.fainelli, davem, netdev, linux-kernel
Cc: chenwandun
Fix following sparse warnings:
drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
drivers/net/dsa/ocelot/felix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 167e415..b7f9246 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -348,8 +348,8 @@ static bool felix_rxtstamp(struct dsa_switch *ds, int port,
return false;
}
-bool felix_txtstamp(struct dsa_switch *ds, int port,
- struct sk_buff *clone, unsigned int type)
+static bool felix_txtstamp(struct dsa_switch *ds, int port,
+ struct sk_buff *clone, unsigned int type)
{
struct ocelot *ocelot = ds->priv;
struct ocelot_port *ocelot_port = ocelot->ports[port];
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings
2019-11-22 12:32 [PATCH] net: dsa: ocelot: fix "should it be static?" warnings Chen Wandun
@ 2019-11-22 15:32 ` Vivien Didelot
2019-11-22 18:09 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vivien Didelot @ 2019-11-22 15:32 UTC (permalink / raw)
To: Chen Wandun
Cc: vladimir.oltean, claudiu.manoil, andrew, f.fainelli, davem,
netdev, linux-kernel, chenwandun
On Fri, 22 Nov 2019 20:32:45 +0800, Chen Wandun <chenwandun@huawei.com> wrote:
> Fix following sparse warnings:
> drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?
>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings
2019-11-22 12:32 [PATCH] net: dsa: ocelot: fix "should it be static?" warnings Chen Wandun
2019-11-22 15:32 ` Vivien Didelot
@ 2019-11-22 18:09 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-22 18:09 UTC (permalink / raw)
To: chenwandun
Cc: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
f.fainelli, netdev, linux-kernel
From: Chen Wandun <chenwandun@huawei.com>
Date: Fri, 22 Nov 2019 20:32:45 +0800
> Fix following sparse warnings:
> drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?
>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Next time please indicate _explicitly_ which tree your patch is targetting,
because especially in this case the change is only relevant for "net-next"
Also, please provide a proper Fixes: tag.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-22 18:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 12:32 [PATCH] net: dsa: ocelot: fix "should it be static?" warnings Chen Wandun
2019-11-22 15:32 ` Vivien Didelot
2019-11-22 18:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).