* [PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel
2019-11-20 17:10 [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd Paul Cercueil
@ 2019-11-20 17:10 ` Paul Cercueil
2019-11-23 15:28 ` Sam Ravnborg
2019-11-30 18:35 ` Sam Ravnborg
2019-11-20 17:10 ` [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel Paul Cercueil
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Paul Cercueil @ 2019-11-20 17:10 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Mark Rutland
Cc: od, dri-devel, devicetree, linux-kernel, Paul Cercueil
Add bindings documentation for the Frida 3.5" (320x240 pixels) 24-bit
TFT LCD panel.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
.../bindings/display/panel/frida,frd350h54004.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
diff --git a/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt b/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
new file mode 100644
index 000000000000..8428f8b05b93
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
@@ -0,0 +1,12 @@
+Frida 3.5" (320x240 pixels) 24-bit TFT LCD panel
+
+Required properties:
+- compatible: should be "frida,frd350h54004"
+- power-supply: as specified in the base binding
+
+Optional properties:
+- backlight: as specified in the base binding
+- enable-gpios: as specified in the base binding
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
--
2.24.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel
2019-11-20 17:10 ` [PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel Paul Cercueil
@ 2019-11-23 15:28 ` Sam Ravnborg
2019-11-30 18:35 ` Sam Ravnborg
1 sibling, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2019-11-23 15:28 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, od, dri-devel, devicetree, linux-kernel
Hi Paul.
On Wed, Nov 20, 2019 at 06:10:26PM +0100, Paul Cercueil wrote:
> Add bindings documentation for the Frida 3.5" (320x240 pixels) 24-bit
> TFT LCD panel.
New bindings using the meta-schema (.yaml) syntax please.
Sam
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> .../bindings/display/panel/frida,frd350h54004.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt b/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
> new file mode 100644
> index 000000000000..8428f8b05b93
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
> @@ -0,0 +1,12 @@
> +Frida 3.5" (320x240 pixels) 24-bit TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "frida,frd350h54004"
> +- power-supply: as specified in the base binding
> +
> +Optional properties:
> +- backlight: as specified in the base binding
> +- enable-gpios: as specified in the base binding
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> --
> 2.24.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel
2019-11-20 17:10 ` [PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel Paul Cercueil
2019-11-23 15:28 ` Sam Ravnborg
@ 2019-11-30 18:35 ` Sam Ravnborg
1 sibling, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2019-11-30 18:35 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, od, dri-devel, devicetree, linux-kernel
Hi Paul.
On Wed, Nov 20, 2019 at 06:10:26PM +0100, Paul Cercueil wrote:
> Add bindings documentation for the Frida 3.5" (320x240 pixels) 24-bit
> TFT LCD panel.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> .../bindings/display/panel/frida,frd350h54004.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt b/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
> new file mode 100644
> index 000000000000..8428f8b05b93
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/frida,frd350h54004.txt
> @@ -0,0 +1,12 @@
> +Frida 3.5" (320x240 pixels) 24-bit TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "frida,frd350h54004"
> +- power-supply: as specified in the base binding
> +
> +Optional properties:
> +- backlight: as specified in the base binding
> +- enable-gpios: as specified in the base binding
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
New bindings in meta-schma (yaml) format only.
We are migrating away from the .txt based variants.
Rob has a mega patch so we will soon have a lot of examples to look at.
Sam
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel
2019-11-20 17:10 [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd Paul Cercueil
2019-11-20 17:10 ` [PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel Paul Cercueil
@ 2019-11-20 17:10 ` Paul Cercueil
2019-11-23 15:29 ` Sam Ravnborg
2019-11-30 18:37 ` Sam Ravnborg
2019-11-23 15:27 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd Sam Ravnborg
2019-11-30 18:34 ` Sam Ravnborg
3 siblings, 2 replies; 9+ messages in thread
From: Paul Cercueil @ 2019-11-20 17:10 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Mark Rutland
Cc: od, dri-devel, devicetree, linux-kernel, Paul Cercueil
The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for
instance inside the Anbernic RG-350 handheld gaming console.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 28fa6ba7b767..8c03f7fe461c 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1378,6 +1378,32 @@ static const struct panel_desc evervision_vgg804821 = {
.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
};
+static const struct drm_display_mode frida_frd350h54004_mode = {
+ .clock = 6777,
+ .hdisplay = 320,
+ .hsync_start = 320 + 70,
+ .hsync_end = 320 + 70 + 50,
+ .htotal = 320 + 70 + 50 + 10,
+ .vdisplay = 240,
+ .vsync_start = 240 + 5,
+ .vsync_end = 240 + 5 + 1,
+ .vtotal = 240 + 5 + 1 + 5,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc frida_frd350h54004 = {
+ .modes = &frida_frd350h54004_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 77,
+ .height = 64,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = {
.clock = 32260,
.hdisplay = 800,
@@ -3186,6 +3212,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "evervision,vgg804821",
.data = &evervision_vgg804821,
+ }, {
+ .compatible = "frida,frd350h54004",
+ .data = &frida_frd350h54004,
}, {
.compatible = "foxlink,fl500wvr00-a0t",
.data = &foxlink_fl500wvr00_a0t,
--
2.24.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel
2019-11-20 17:10 ` [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel Paul Cercueil
@ 2019-11-23 15:29 ` Sam Ravnborg
2019-11-30 18:37 ` Sam Ravnborg
1 sibling, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2019-11-23 15:29 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, od, dri-devel, devicetree, linux-kernel
Hi Paul.
On Wed, Nov 20, 2019 at 06:10:27PM +0100, Paul Cercueil wrote:
> The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for
> instance inside the Anbernic RG-350 handheld gaming console.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 28fa6ba7b767..8c03f7fe461c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1378,6 +1378,32 @@ static const struct panel_desc evervision_vgg804821 = {
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
> };
>
> +static const struct drm_display_mode frida_frd350h54004_mode = {
> + .clock = 6777,
> + .hdisplay = 320,
> + .hsync_start = 320 + 70,
> + .hsync_end = 320 + 70 + 50,
> + .htotal = 320 + 70 + 50 + 10,
> + .vdisplay = 240,
> + .vsync_start = 240 + 5,
> + .vsync_end = 240 + 5 + 1,
> + .vtotal = 240 + 5 + 1 + 5,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc frida_frd350h54004 = {
> + .modes = &frida_frd350h54004_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 77,
> + .height = 64,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
> +};
> +
> static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = {
> .clock = 32260,
> .hdisplay = 800,
> @@ -3186,6 +3212,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "evervision,vgg804821",
> .data = &evervision_vgg804821,
> + }, {
> + .compatible = "frida,frd350h54004",
> + .data = &frida_frd350h54004,
> }, {
> .compatible = "foxlink,fl500wvr00-a0t",
> .data = &foxlink_fl500wvr00_a0t,
In alphabetic order. frida comes after fox.
Sam
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel
2019-11-20 17:10 ` [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel Paul Cercueil
2019-11-23 15:29 ` Sam Ravnborg
@ 2019-11-30 18:37 ` Sam Ravnborg
1 sibling, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2019-11-30 18:37 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, od, dri-devel, devicetree, linux-kernel
Hi Paul.
I am not sure if I already wrote this...
On Wed, Nov 20, 2019 at 06:10:27PM +0100, Paul Cercueil wrote:
> The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for
> instance inside the Anbernic RG-350 handheld gaming console.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 28fa6ba7b767..8c03f7fe461c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1378,6 +1378,32 @@ static const struct panel_desc evervision_vgg804821 = {
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE,
> };
>
> +static const struct drm_display_mode frida_frd350h54004_mode = {
> + .clock = 6777,
> + .hdisplay = 320,
> + .hsync_start = 320 + 70,
> + .hsync_end = 320 + 70 + 50,
> + .htotal = 320 + 70 + 50 + 10,
> + .vdisplay = 240,
> + .vsync_start = 240 + 5,
> + .vsync_end = 240 + 5 + 1,
> + .vtotal = 240 + 5 + 1 + 5,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc frida_frd350h54004 = {
> + .modes = &frida_frd350h54004_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 77,
> + .height = 64,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
> +};
> +
> static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = {
> .clock = 32260,
> .hdisplay = 800,
In alphabetic order. frida comes after foxlink.
> @@ -3186,6 +3212,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "evervision,vgg804821",
> .data = &evervision_vgg804821,
> + }, {
> + .compatible = "frida,frd350h54004",
> + .data = &frida_frd350h54004,
> }, {
> .compatible = "foxlink,fl500wvr00-a0t",
> .data = &foxlink_fl500wvr00_a0t,
In alphabetic order. frida comes after foxlink.
Sam
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd.
2019-11-20 17:10 [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd Paul Cercueil
2019-11-20 17:10 ` [PATCH 2/3] dt-bindings: panel: Document Frida FRD350H54004 LCD panel Paul Cercueil
2019-11-20 17:10 ` [PATCH 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel Paul Cercueil
@ 2019-11-23 15:27 ` Sam Ravnborg
2019-11-30 18:34 ` Sam Ravnborg
3 siblings, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2019-11-23 15:27 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, od, dri-devel, devicetree, linux-kernel
Hi Paul.
On Wed, Nov 20, 2019 at 06:10:25PM +0100, Paul Cercueil wrote:
> Add an entry for Shenzhen Frida LCD Co., Ltd.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 967e78c5ec0a..9c6e1b42435b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -337,6 +337,8 @@ patternProperties:
> description: Firefly
> "^focaltech,.*":
> description: FocalTech Systems Co.,Ltd
> + "^frida,.*":
> + description: Shenzhen Frida LCD Co., Ltd.
Random note:
Some descriptions end with a '.,', others not.
So both works.
> "^friendlyarm,.*":
> description: Guangzhou FriendlyARM Computer Tech Co., Ltd
> "^fsl,.*":
> --
> 2.24.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd.
2019-11-20 17:10 [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd Paul Cercueil
` (2 preceding siblings ...)
2019-11-23 15:27 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Frida LCD Co., Ltd Sam Ravnborg
@ 2019-11-30 18:34 ` Sam Ravnborg
3 siblings, 0 replies; 9+ messages in thread
From: Sam Ravnborg @ 2019-11-30 18:34 UTC (permalink / raw)
To: Paul Cercueil
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, od, dri-devel, devicetree, linux-kernel
On Wed, Nov 20, 2019 at 06:10:25PM +0100, Paul Cercueil wrote:
> Add an entry for Shenzhen Frida LCD Co., Ltd.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 967e78c5ec0a..9c6e1b42435b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -337,6 +337,8 @@ patternProperties:
> description: Firefly
> "^focaltech,.*":
> description: FocalTech Systems Co.,Ltd
> + "^frida,.*":
> + description: Shenzhen Frida LCD Co., Ltd.
> "^friendlyarm,.*":
> description: Guangzhou FriendlyARM Computer Tech Co., Ltd
> "^fsl,.*":
> --
> 2.24.0
^ permalink raw reply [flat|nested] 9+ messages in thread