linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 05/16] scripts/kallsyms: remove redundant is_arm_mapping_symbol()
Date: Sun, 24 Nov 2019 01:04:33 +0900	[thread overview]
Message-ID: <20191123160444.11251-6-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <20191123160444.11251-1-yamada.masahiro@socionext.com>

Since commit 6f00df24ee39 ("[PATCH] Strip local symbols from kallsyms"),
all symbols starting '$' are ignored.

is_arm_mapping_symbol() particularly ignores $a, $t, etc. but it is
redundant.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v2: None

 scripts/kallsyms.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index c9efb67c6ecb..14a50c8d3f34 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -74,16 +74,6 @@ static void usage(void)
 	exit(1);
 }
 
-/*
- * This ignores the intensely annoying "mapping symbols" found
- * in ARM ELF files: $a, $t and $d.
- */
-static int is_arm_mapping_symbol(const char *str)
-{
-	return str[0] == '$' && strchr("axtd", str[1])
-	       && (str[2] == '\0' || str[2] == '.');
-}
-
 static int check_symbol_range(const char *sym, unsigned long long addr,
 			      struct addr_range *ranges, int entries)
 {
@@ -139,10 +129,13 @@ static int read_symbol(FILE *in, struct sym_entry *s)
 			return -1;
 
 	}
-	else if (toupper(stype) == 'U' ||
-		 is_arm_mapping_symbol(sym))
+	else if (toupper(stype) == 'U')
 		return -1;
-	/* exclude also MIPS ELF local symbols ($L123 instead of .L123) */
+	/*
+	 * Ignore generated symbols such as:
+	 *  - mapping symbols in ARM ELF files ($a, $t, and $d)
+	 *  - MIPS ELF local symbols ($L123 instead of .L123)
+	 */
 	else if (sym[0] == '$')
 		return -1;
 	/* exclude debugging symbols */
-- 
2.17.1


  parent reply	other threads:[~2019-11-23 16:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 16:04 [PATCH v2 00/16] scripts/kallsyms: various cleanups and optimizations Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 01/16] scripts/kallsyms: remove unneeded #ifndef ARRAY_SIZE Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 02/16] scripts/kallsyms: fix definitely-lost memory leak Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 03/16] scripts/kallsyms: shrink table before sorting it Masahiro Yamada
2019-12-07 22:19   ` Olof Johansson
2019-11-23 16:04 ` [PATCH v2 04/16] scripts/kallsyms: set relative_base more effectively Masahiro Yamada
2019-11-23 16:04 ` Masahiro Yamada [this message]
2019-11-23 16:04 ` [PATCH v2 06/16] scripts/kallsyms: remove unneeded length check for prefix matching Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 07/16] scripts/kallsyms: add sym_name() to mitigate cast ugliness Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 08/16] scripts/kallsyms: replace prefix_underscores_count() with strspn() Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 09/16] scripts/kallsyms: make find_token() return (unsigned char *) Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 10/16] scripts/kallsyms: add const qualifiers where possible Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 11/16] scripts/kallsyms: skip ignored symbols very early Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 12/16] scripts/kallsyms: move more patterns to the ignored_prefixes array Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 13/16] scripts/kallsyms: move ignored symbol types to is_ignored_symbol() Masahiro Yamada
2020-07-20  1:46   ` Finn Thain
2020-07-20  5:34     ` Masahiro Yamada
2020-07-21  4:00       ` Finn Thain
2019-11-23 16:04 ` [PATCH v2 14/16] scripts/kallsyms: make check_symbol_range() void function Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 15/16] scripts/kallsyms: put check_symbol_range() calls close together Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 16/16] scripts/kallsyms: remove redundant initializers Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191123160444.11251-6-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).