From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 08/16] scripts/kallsyms: replace prefix_underscores_count() with strspn()
Date: Sun, 24 Nov 2019 01:04:36 +0900 [thread overview]
Message-ID: <20191123160444.11251-9-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <20191123160444.11251-1-yamada.masahiro@socionext.com>
You can do equivalent things with strspn(). I do not see noticeable
performance difference.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v2: None
scripts/kallsyms.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index baa2fa5692b0..89cc7c098c51 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -661,16 +661,6 @@ static int may_be_linker_script_provide_symbol(const struct sym_entry *se)
return 0;
}
-static int prefix_underscores_count(const char *str)
-{
- const char *tail = str;
-
- while (*tail == '_')
- tail++;
-
- return tail - str;
-}
-
static int compare_symbols(const void *a, const void *b)
{
const struct sym_entry *sa;
@@ -699,8 +689,8 @@ static int compare_symbols(const void *a, const void *b)
return wa - wb;
/* sort by the number of prefix underscores */
- wa = prefix_underscores_count(sym_name(sa));
- wb = prefix_underscores_count(sym_name(sb));
+ wa = strspn(sym_name(sa), "_");
+ wb = strspn(sym_name(sb), "_");
if (wa != wb)
return wa - wb;
--
2.17.1
next prev parent reply other threads:[~2019-11-23 16:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 16:04 [PATCH v2 00/16] scripts/kallsyms: various cleanups and optimizations Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 01/16] scripts/kallsyms: remove unneeded #ifndef ARRAY_SIZE Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 02/16] scripts/kallsyms: fix definitely-lost memory leak Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 03/16] scripts/kallsyms: shrink table before sorting it Masahiro Yamada
2019-12-07 22:19 ` Olof Johansson
2019-11-23 16:04 ` [PATCH v2 04/16] scripts/kallsyms: set relative_base more effectively Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 05/16] scripts/kallsyms: remove redundant is_arm_mapping_symbol() Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 06/16] scripts/kallsyms: remove unneeded length check for prefix matching Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 07/16] scripts/kallsyms: add sym_name() to mitigate cast ugliness Masahiro Yamada
2019-11-23 16:04 ` Masahiro Yamada [this message]
2019-11-23 16:04 ` [PATCH v2 09/16] scripts/kallsyms: make find_token() return (unsigned char *) Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 10/16] scripts/kallsyms: add const qualifiers where possible Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 11/16] scripts/kallsyms: skip ignored symbols very early Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 12/16] scripts/kallsyms: move more patterns to the ignored_prefixes array Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 13/16] scripts/kallsyms: move ignored symbol types to is_ignored_symbol() Masahiro Yamada
2020-07-20 1:46 ` Finn Thain
2020-07-20 5:34 ` Masahiro Yamada
2020-07-21 4:00 ` Finn Thain
2019-11-23 16:04 ` [PATCH v2 14/16] scripts/kallsyms: make check_symbol_range() void function Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 15/16] scripts/kallsyms: put check_symbol_range() calls close together Masahiro Yamada
2019-11-23 16:04 ` [PATCH v2 16/16] scripts/kallsyms: remove redundant initializers Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191123160444.11251-9-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).