From: Phong Tran <tranmanphong@gmail.com>
To: davem@davemloft.net, keescook@chromium.org
Cc: kvalo@codeaurora.org, saeedm@mellanox.com,
jeffrey.t.kirsher@intel.com, luciano.coelho@intel.com,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Phong Tran <tranmanphong@gmail.com>
Subject: [PATCH 3/5] drivers: net: b43legacy: Fix -Wcast-function-type
Date: Sun, 24 Nov 2019 16:43:04 +0700 [thread overview]
Message-ID: <20191124094306.21297-4-tranmanphong@gmail.com> (raw)
In-Reply-To: <20191124094306.21297-1-tranmanphong@gmail.com>
correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
drivers/net/wireless/broadcom/b43legacy/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
index 4325e91736eb..8b6b657c4b85 100644
--- a/drivers/net/wireless/broadcom/b43legacy/main.c
+++ b/drivers/net/wireless/broadcom/b43legacy/main.c
@@ -1275,8 +1275,9 @@ static void handle_irq_ucode_debug(struct b43legacy_wldev *dev)
}
/* Interrupt handler bottom-half */
-static void b43legacy_interrupt_tasklet(struct b43legacy_wldev *dev)
+static void b43legacy_interrupt_tasklet(unsigned long data)
{
+ struct b43legacy_wldev *dev = (struct b43legacy_wldev *)data;
u32 reason;
u32 dma_reason[ARRAY_SIZE(dev->dma_reason)];
u32 merged_dma_reason = 0;
@@ -3741,7 +3742,7 @@ static int b43legacy_one_core_attach(struct ssb_device *dev,
b43legacy_set_status(wldev, B43legacy_STAT_UNINIT);
wldev->bad_frames_preempt = modparam_bad_frames_preempt;
tasklet_init(&wldev->isr_tasklet,
- (void (*)(unsigned long))b43legacy_interrupt_tasklet,
+ b43legacy_interrupt_tasklet,
(unsigned long)wldev);
if (modparam_pio)
wldev->__using_pio = true;
--
2.20.1
next prev parent reply other threads:[~2019-11-24 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 9:43 [PATCH 0/5] Fix -Wcast-function-type net drivers Phong Tran
2019-11-24 9:43 ` [PATCH 1/5] drivers: net: hso: Fix -Wcast-function-type Phong Tran
2019-11-24 9:43 ` [PATCH 2/5] drivers: net: usbnet: " Phong Tran
2019-11-24 9:43 ` Phong Tran [this message]
2019-11-25 18:30 ` [PATCH 3/5] drivers: net: b43legacy: " Larry Finger
2019-11-24 9:43 ` [PATCH 4/5] drivers: net: intel: " Phong Tran
2019-11-24 9:43 ` [PATCH 5/5] drivers: net: realtek: " Phong Tran
2019-11-24 22:39 ` [PATCH 0/5] Fix -Wcast-function-type net drivers Jakub Kicinski
2019-11-25 15:06 ` Phong Tran
2019-11-25 17:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124094306.21297-4-tranmanphong@gmail.com \
--to=tranmanphong@gmail.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).