From: Phong Tran <tranmanphong@gmail.com>
To: davem@davemloft.net, keescook@chromium.org
Cc: kvalo@codeaurora.org, saeedm@mellanox.com,
jeffrey.t.kirsher@intel.com, luciano.coelho@intel.com,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Phong Tran <tranmanphong@gmail.com>
Subject: [PATCH 5/5] drivers: net: realtek: Fix -Wcast-function-type
Date: Sun, 24 Nov 2019 16:43:06 +0700 [thread overview]
Message-ID: <20191124094306.21297-6-tranmanphong@gmail.com> (raw)
In-Reply-To: <20191124094306.21297-1-tranmanphong@gmail.com>
correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c
index f88d26535978..25335bd2873b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/pci.c
+++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
@@ -1061,13 +1061,15 @@ static irqreturn_t _rtl_pci_interrupt(int irq, void *dev_id)
return ret;
}
-static void _rtl_pci_irq_tasklet(struct ieee80211_hw *hw)
+static void _rtl_pci_irq_tasklet(unsigned long data)
{
+ struct ieee80211_hw *hw = (struct ieee80211_hw *)data;
_rtl_pci_tx_chk_waitq(hw);
}
-static void _rtl_pci_prepare_bcn_tasklet(struct ieee80211_hw *hw)
+static void _rtl_pci_prepare_bcn_tasklet(unsigned long data)
{
+ struct ieee80211_hw *hw = (struct ieee80211_hw *)data;
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
@@ -1193,10 +1195,10 @@ static void _rtl_pci_init_struct(struct ieee80211_hw *hw,
/*task */
tasklet_init(&rtlpriv->works.irq_tasklet,
- (void (*)(unsigned long))_rtl_pci_irq_tasklet,
+ _rtl_pci_irq_tasklet,
(unsigned long)hw);
tasklet_init(&rtlpriv->works.irq_prepare_bcn_tasklet,
- (void (*)(unsigned long))_rtl_pci_prepare_bcn_tasklet,
+ _rtl_pci_prepare_bcn_tasklet,
(unsigned long)hw);
INIT_WORK(&rtlpriv->works.lps_change_work,
rtl_lps_change_work_callback);
--
2.20.1
next prev parent reply other threads:[~2019-11-24 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 9:43 [PATCH 0/5] Fix -Wcast-function-type net drivers Phong Tran
2019-11-24 9:43 ` [PATCH 1/5] drivers: net: hso: Fix -Wcast-function-type Phong Tran
2019-11-24 9:43 ` [PATCH 2/5] drivers: net: usbnet: " Phong Tran
2019-11-24 9:43 ` [PATCH 3/5] drivers: net: b43legacy: " Phong Tran
2019-11-25 18:30 ` Larry Finger
2019-11-24 9:43 ` [PATCH 4/5] drivers: net: intel: " Phong Tran
2019-11-24 9:43 ` Phong Tran [this message]
2019-11-24 22:39 ` [PATCH 0/5] Fix -Wcast-function-type net drivers Jakub Kicinski
2019-11-25 15:06 ` Phong Tran
2019-11-25 17:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124094306.21297-6-tranmanphong@gmail.com \
--to=tranmanphong@gmail.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).