From: Mark Brown <broonie@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Lucas Stach <l.stach@pengutronix.de>,
"Andrew F. Davis" <afd@ti.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Add HP output driver pop reduction controls
Date: Thu, 28 Nov 2019 12:11:28 +0000 [thread overview]
Message-ID: <20191128121128.GA4210@sirena.org.uk> (raw)
In-Reply-To: <20191128093955.29567-1-nikita.yoush@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Thu, Nov 28, 2019 at 12:39:55PM +0300, Nikita Yushchenko wrote:
> +static const char * const hp_poweron_time_text[] = {
> + "0us", "15.3us", "153us", "1.53ms", "15.3ms", "76.2ms",
> + "153ms", "304ms", "610ms", "1.22s", "3.04s", "6.1s" };
> +
> +static SOC_ENUM_SINGLE_DECL(hp_poweron_time_enum, AIC31XX_HPPOP, 3,
> + hp_poweron_time_text);
> +
> +static const char * const hp_rampup_step_text[] = {
> + "0ms", "0.98ms", "1.95ms", "3.9ms" };
> +
> +static SOC_ENUM_SINGLE_DECL(hp_rampup_step_enum, AIC31XX_HPPOP, 1,
> + hp_rampup_step_text);
I'm not seeing any integration with DAPM here, I'd expect to see that so
we don't cut off the start of audio especially with the longer times
available (which I'm frankly not sure are seriously usable).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-28 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 9:39 [PATCH] ASoC: tlv320aic31xx: Add HP output driver pop reduction controls Nikita Yushchenko
2019-11-28 12:11 ` Mark Brown [this message]
2019-11-28 12:19 ` Nikita Yushchenko
2019-11-28 12:23 ` Mark Brown
2019-11-28 13:54 ` [PATCH v2] " Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128121128.GA4210@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=cphealy@gmail.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).