From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Lucas Stach <l.stach@pengutronix.de>,
"Andrew F. Davis" <afd@ti.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Add HP output driver pop reduction controls
Date: Thu, 28 Nov 2019 15:19:38 +0300 [thread overview]
Message-ID: <ecfa48d3-284b-5234-02b9-adc0c6892b6f@cogentembedded.com> (raw)
In-Reply-To: <20191128121128.GA4210@sirena.org.uk>
>> +static const char * const hp_poweron_time_text[] = {
>> + "0us", "15.3us", "153us", "1.53ms", "15.3ms", "76.2ms",
>> + "153ms", "304ms", "610ms", "1.22s", "3.04s", "6.1s" };
>> +
>> +static SOC_ENUM_SINGLE_DECL(hp_poweron_time_enum, AIC31XX_HPPOP, 3,
>> + hp_poweron_time_text);
>> +
>> +static const char * const hp_rampup_step_text[] = {
>> + "0ms", "0.98ms", "1.95ms", "3.9ms" };
>> +
>> +static SOC_ENUM_SINGLE_DECL(hp_rampup_step_enum, AIC31XX_HPPOP, 1,
>> + hp_rampup_step_text);
>
> I'm not seeing any integration with DAPM here, I'd expect to see that so
> we don't cut off the start of audio especially with the longer times
> available (which I'm frankly not sure are seriously usable).
I believe driver already has that integration, there is aic31xx_dapm_power_event() that is called on
DAPM events, and polls state in register bits waiting for operation to complete.
Btw, the default setting for register fields in question is "304ms" / "3.9ms" thus some delay is already
there. This patch just makes it explicitly controllable by those who wait it.
next prev parent reply other threads:[~2019-11-28 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 9:39 [PATCH] ASoC: tlv320aic31xx: Add HP output driver pop reduction controls Nikita Yushchenko
2019-11-28 12:11 ` Mark Brown
2019-11-28 12:19 ` Nikita Yushchenko [this message]
2019-11-28 12:23 ` Mark Brown
2019-11-28 13:54 ` [PATCH v2] " Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecfa48d3-284b-5234-02b9-adc0c6892b6f@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cphealy@gmail.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).