[PATCH] erofs: zero out when listxattr is called with no xattr

* [PATCH] erofs: zero out when listxattr is called with no xattr
       [not found] <20191201084040.29275-1-hsiangkao.ref@aol.com>
@ 2019-12-01  8:40 ` Gao Xiang
       [not found]   ` <20191202221312.8F590206F0@mail.kernel.org>
  2019-12-04  3:14   ` Chao Yu
  0 siblings, 2 replies; 3+ messages in thread
From: Gao Xiang @ 2019-12-01  8:40 UTC (permalink / raw)
  To: Chao Yu, linux-erofs
  Cc: LKML, David Michael, Miao Xie, Fang Wei, Wang Li, Gao Xiang, stable

From: Gao Xiang <gaoxiang25@huawei.com>

As David reported [1], ENODATA returns when attempting
to modify files by using EROFS as a overlayfs lower layer.

The root cause is that listxattr could return unexpected
-ENODATA by mistake for inodes without xattr. That breaks
listxattr return value convention and it can cause copy
up failure when used with overlayfs.

Resolve by zeroing out if no xattr is found for listxattr.

[1] https://lore.kernel.org/r/CAEvUa7nxnby+rxK-KRMA46=exeOMApkDMAV08AjMkkPnTPV4CQ@mail.gmail.com
Fixes: cadf1ccf1b00 ("staging: erofs: add error handling for xattr submodule")
Cc: <stable@vger.kernel.org> # 4.19+
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
---
 fs/erofs/xattr.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c
index a13a78725c57..b766c3ee5fa8 100644
--- a/fs/erofs/xattr.c
+++ b/fs/erofs/xattr.c
@@ -649,6 +649,8 @@ ssize_t erofs_listxattr(struct dentry *dentry,
 	struct listxattr_iter it;
 
 	ret = init_inode_xattrs(d_inode(dentry));
+	if (ret == -ENOATTR)
+		return 0;
 	if (ret)
 		return ret;
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread