* [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode
@ 2019-12-04 7:19 Chaotian Jing
2019-12-04 8:11 ` Hsin-Yi Wang
2019-12-10 9:51 ` Ulf Hansson
0 siblings, 2 replies; 5+ messages in thread
From: Chaotian Jing @ 2019-12-04 7:19 UTC (permalink / raw)
To: Ulf Hansson
Cc: Chaotian Jing, Matthias Brugger, linux-mmc, linux-arm-kernel,
linux-mediatek, linux-kernel, srv_heupstream, hsinyi
there is a chance that always get response CRC error after HS200 tuning,
the reason is that need set CMD_TA to 2. this modification is only for
MT8173.
Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
drivers/mmc/host/mtk-sd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 189e42674d85..010fe29a4888 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -228,6 +228,7 @@
#define MSDC_PATCH_BIT_SPCPUSH (0x1 << 29) /* RW */
#define MSDC_PATCH_BIT_DECRCTMO (0x1 << 30) /* RW */
+#define MSDC_PATCH_BIT1_CMDTA (0x7 << 3) /* RW */
#define MSDC_PATCH_BIT1_STOP_DLY (0xf << 8) /* RW */
#define MSDC_PATCH_BIT2_CFGRESP (0x1 << 15) /* RW */
@@ -1881,6 +1882,7 @@ static int hs400_tune_response(struct mmc_host *mmc, u32 opcode)
/* select EMMC50 PAD CMD tune */
sdr_set_bits(host->base + PAD_CMD_TUNE, BIT(0));
+ sdr_set_field(host->base + MSDC_PATCH_BIT1, MSDC_PATCH_BIT1_CMDTA, 2);
if (mmc->ios.timing == MMC_TIMING_MMC_HS200 ||
mmc->ios.timing == MMC_TIMING_UHS_SDR104)
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode
2019-12-04 7:19 [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode Chaotian Jing
@ 2019-12-04 8:11 ` Hsin-Yi Wang
2019-12-10 9:51 ` Ulf Hansson
1 sibling, 0 replies; 5+ messages in thread
From: Hsin-Yi Wang @ 2019-12-04 8:11 UTC (permalink / raw)
To: Chaotian Jing
Cc: Ulf Hansson, Matthias Brugger, linux-mmc, linux-arm-kernel,
linux-mediatek, linux-kernel, srv_heupstream
On Wed, Dec 4, 2019 at 3:20 PM Chaotian Jing <chaotian.jing@mediatek.com> wrote:
>
> there is a chance that always get response CRC error after HS200 tuning,
> the reason is that need set CMD_TA to 2. this modification is only for
> MT8173.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode
2019-12-04 7:19 [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode Chaotian Jing
2019-12-04 8:11 ` Hsin-Yi Wang
@ 2019-12-10 9:51 ` Ulf Hansson
2019-12-10 12:03 ` Chaotian Jing
1 sibling, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2019-12-10 9:51 UTC (permalink / raw)
To: Chaotian Jing
Cc: Matthias Brugger, linux-mmc, Linux ARM, linux-mediatek,
Linux Kernel Mailing List, srv_heupstream, hsinyi
On Wed, 4 Dec 2019 at 08:20, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
>
> there is a chance that always get response CRC error after HS200 tuning,
> the reason is that need set CMD_TA to 2. this modification is only for
> MT8173.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
I have applied this for fixes, however it seems like this should also
be tagged for stable, right?
Is there a specific commit this fixes or should we just find the
version it applies to?
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 189e42674d85..010fe29a4888 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -228,6 +228,7 @@
> #define MSDC_PATCH_BIT_SPCPUSH (0x1 << 29) /* RW */
> #define MSDC_PATCH_BIT_DECRCTMO (0x1 << 30) /* RW */
>
> +#define MSDC_PATCH_BIT1_CMDTA (0x7 << 3) /* RW */
> #define MSDC_PATCH_BIT1_STOP_DLY (0xf << 8) /* RW */
>
> #define MSDC_PATCH_BIT2_CFGRESP (0x1 << 15) /* RW */
> @@ -1881,6 +1882,7 @@ static int hs400_tune_response(struct mmc_host *mmc, u32 opcode)
>
> /* select EMMC50 PAD CMD tune */
> sdr_set_bits(host->base + PAD_CMD_TUNE, BIT(0));
> + sdr_set_field(host->base + MSDC_PATCH_BIT1, MSDC_PATCH_BIT1_CMDTA, 2);
>
> if (mmc->ios.timing == MMC_TIMING_MMC_HS200 ||
> mmc->ios.timing == MMC_TIMING_UHS_SDR104)
> --
> 2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode
2019-12-10 9:51 ` Ulf Hansson
@ 2019-12-10 12:03 ` Chaotian Jing
2019-12-10 12:42 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Chaotian Jing @ 2019-12-10 12:03 UTC (permalink / raw)
To: Ulf Hansson
Cc: srv_heupstream, linux-mmc, Linux Kernel Mailing List,
linux-mediatek, Matthias Brugger, hsinyi, Linux ARM
On Tue, 2019-12-10 at 10:51 +0100, Ulf Hansson wrote:
> On Wed, 4 Dec 2019 at 08:20, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> >
> > there is a chance that always get response CRC error after HS200 tuning,
> > the reason is that need set CMD_TA to 2. this modification is only for
> > MT8173.
> >
> > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
>
> I have applied this for fixes, however it seems like this should also
> be tagged for stable, right?
> Yes! should be tagged for stable.
> Is there a specific commit this fixes or should we just find the
> version it applies to?
>
this patch should be a fix to commit:
1ede5cb88a29bba1aad1b68965c5fc8e00b20ed9
> Kind regards
> Uffe
>
>
>
> > ---
> > drivers/mmc/host/mtk-sd.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> > index 189e42674d85..010fe29a4888 100644
> > --- a/drivers/mmc/host/mtk-sd.c
> > +++ b/drivers/mmc/host/mtk-sd.c
> > @@ -228,6 +228,7 @@
> > #define MSDC_PATCH_BIT_SPCPUSH (0x1 << 29) /* RW */
> > #define MSDC_PATCH_BIT_DECRCTMO (0x1 << 30) /* RW */
> >
> > +#define MSDC_PATCH_BIT1_CMDTA (0x7 << 3) /* RW */
> > #define MSDC_PATCH_BIT1_STOP_DLY (0xf << 8) /* RW */
> >
> > #define MSDC_PATCH_BIT2_CFGRESP (0x1 << 15) /* RW */
> > @@ -1881,6 +1882,7 @@ static int hs400_tune_response(struct mmc_host *mmc, u32 opcode)
> >
> > /* select EMMC50 PAD CMD tune */
> > sdr_set_bits(host->base + PAD_CMD_TUNE, BIT(0));
> > + sdr_set_field(host->base + MSDC_PATCH_BIT1, MSDC_PATCH_BIT1_CMDTA, 2);
> >
> > if (mmc->ios.timing == MMC_TIMING_MMC_HS200 ||
> > mmc->ios.timing == MMC_TIMING_UHS_SDR104)
> > --
> > 2.18.0
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode
2019-12-10 12:03 ` Chaotian Jing
@ 2019-12-10 12:42 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2019-12-10 12:42 UTC (permalink / raw)
To: Chaotian Jing
Cc: srv_heupstream, linux-mmc, Linux Kernel Mailing List,
linux-mediatek, Matthias Brugger, hsinyi, Linux ARM
On Tue, 10 Dec 2019 at 13:03, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
>
> On Tue, 2019-12-10 at 10:51 +0100, Ulf Hansson wrote:
> > On Wed, 4 Dec 2019 at 08:20, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> > >
> > > there is a chance that always get response CRC error after HS200 tuning,
> > > the reason is that need set CMD_TA to 2. this modification is only for
> > > MT8173.
> > >
> > > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
> >
> > I have applied this for fixes, however it seems like this should also
> > be tagged for stable, right?
> > Yes! should be tagged for stable.
> > Is there a specific commit this fixes or should we just find the
> > version it applies to?
> >
> this patch should be a fix to commit:
> 1ede5cb88a29bba1aad1b68965c5fc8e00b20ed9
Perfect, I add that!
[...]
Kind regards
Uffe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-10 12:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 7:19 [PATCH] mmc: mediatek: fix CMD_TA to 2 for MT8173 HS200/HS400 mode Chaotian Jing
2019-12-04 8:11 ` Hsin-Yi Wang
2019-12-10 9:51 ` Ulf Hansson
2019-12-10 12:03 ` Chaotian Jing
2019-12-10 12:42 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).