* [PATCH] hexagon: io: Define ioremap_uc to fix build error
@ 2019-12-04 13:33 Guenter Roeck
2019-12-09 14:40 ` Andy Shevchenko
2019-12-10 8:09 ` Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-12-04 13:33 UTC (permalink / raw)
To: Brian Cain
Cc: linux-hexagon, linux-kernel, Guenter Roeck, Tuowen Zhao,
Mika Westerberg, Andy Shevchenko, Luis Chamberlain, Lee Jones
ioremap_uc is now mandatory.
lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
Cc: Tuowen Zhao <ztuowen@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/hexagon/include/asm/io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
index 539e3efcf39c..39e5605c5d42 100644
--- a/arch/hexagon/include/asm/io.h
+++ b/arch/hexagon/include/asm/io.h
@@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
#define ioremap_nocache ioremap
-
+#define ioremap_uc ioremap
#define __raw_writel writel
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] hexagon: io: Define ioremap_uc to fix build error
2019-12-04 13:33 [PATCH] hexagon: io: Define ioremap_uc to fix build error Guenter Roeck
@ 2019-12-09 14:40 ` Andy Shevchenko
2019-12-10 8:09 ` Geert Uytterhoeven
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2019-12-09 14:40 UTC (permalink / raw)
To: Guenter Roeck
Cc: Brian Cain, linux-hexagon, linux-kernel, Tuowen Zhao,
Mika Westerberg, Luis Chamberlain, Lee Jones
On Wed, Dec 04, 2019 at 05:33:28AM -0800, Guenter Roeck wrote:
> ioremap_uc is now mandatory.
>
> lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
Thanks for a fix!
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
> Cc: Tuowen Zhao <ztuowen@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/hexagon/include/asm/io.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
> index 539e3efcf39c..39e5605c5d42 100644
> --- a/arch/hexagon/include/asm/io.h
> +++ b/arch/hexagon/include/asm/io.h
> @@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
>
> void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
> #define ioremap_nocache ioremap
> -
> +#define ioremap_uc ioremap
>
> #define __raw_writel writel
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hexagon: io: Define ioremap_uc to fix build error
2019-12-04 13:33 [PATCH] hexagon: io: Define ioremap_uc to fix build error Guenter Roeck
2019-12-09 14:40 ` Andy Shevchenko
@ 2019-12-10 8:09 ` Geert Uytterhoeven
2019-12-10 8:23 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-10 8:09 UTC (permalink / raw)
To: Guenter Roeck
Cc: Brian Cain, open list:QUALCOMM HEXAGON...,
Linux Kernel Mailing List, Tuowen Zhao, Mika Westerberg,
Andy Shevchenko, Luis Chamberlain, Lee Jones
On Wed, Dec 4, 2019 at 2:34 PM Guenter Roeck <linux@roeck-us.net> wrote:
> ioremap_uc is now mandatory.
>
> lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
>
> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
> Cc: Tuowen Zhao <ztuowen@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/hexagon/include/asm/io.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
> index 539e3efcf39c..39e5605c5d42 100644
> --- a/arch/hexagon/include/asm/io.h
> +++ b/arch/hexagon/include/asm/io.h
> @@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
>
> void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
> #define ioremap_nocache ioremap
> -
> +#define ioremap_uc ioremap
>
> #define __raw_writel writel
Do we really need this? There is only one user of ioremap_uc(), which
Christoph is trying hard to get rid of, and the new devres helper that
triggers all of this :-(
https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hexagon: io: Define ioremap_uc to fix build error
2019-12-10 8:09 ` Geert Uytterhoeven
@ 2019-12-10 8:23 ` Guenter Roeck
2019-12-10 8:45 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2019-12-10 8:23 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Brian Cain, open list:QUALCOMM HEXAGON...,
Linux Kernel Mailing List, Tuowen Zhao, Mika Westerberg,
Andy Shevchenko, Luis Chamberlain, Lee Jones
On 12/10/19 12:09 AM, Geert Uytterhoeven wrote:
> On Wed, Dec 4, 2019 at 2:34 PM Guenter Roeck <linux@roeck-us.net> wrote:
>> ioremap_uc is now mandatory.
>>
>> lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
>>
>> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
>> Cc: Tuowen Zhao <ztuowen@gmail.com>
>> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> arch/hexagon/include/asm/io.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
>> index 539e3efcf39c..39e5605c5d42 100644
>> --- a/arch/hexagon/include/asm/io.h
>> +++ b/arch/hexagon/include/asm/io.h
>> @@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
>>
>> void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
>> #define ioremap_nocache ioremap
>> -
>> +#define ioremap_uc ioremap
>>
>> #define __raw_writel writel
>
> Do we really need this? There is only one user of ioremap_uc(), which
> Christoph is trying hard to get rid of, and the new devres helper that
> triggers all of this :-(
> https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/
>
One may ask why we needed a devres helper in the first place if there
is indeed just one user.
Either case, I don't really care, as long as the problem is fixed.
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hexagon: io: Define ioremap_uc to fix build error
2019-12-10 8:23 ` Guenter Roeck
@ 2019-12-10 8:45 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-10 8:45 UTC (permalink / raw)
To: Guenter Roeck
Cc: Brian Cain, open list:QUALCOMM HEXAGON...,
Linux Kernel Mailing List, Tuowen Zhao, Mika Westerberg,
Andy Shevchenko, Luis Chamberlain, Lee Jones
Hi Günter,
On Tue, Dec 10, 2019 at 9:23 AM Guenter Roeck <linux@roeck-us.net> wrote:
> On 12/10/19 12:09 AM, Geert Uytterhoeven wrote:
> > On Wed, Dec 4, 2019 at 2:34 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >> ioremap_uc is now mandatory.
> >>
> >> lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
> >>
> >> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
> >> Cc: Tuowen Zhao <ztuowen@gmail.com>
> >> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Cc: Luis Chamberlain <mcgrof@kernel.org>
> >> Cc: Lee Jones <lee.jones@linaro.org>
> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> >> ---
> >> arch/hexagon/include/asm/io.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
> >> index 539e3efcf39c..39e5605c5d42 100644
> >> --- a/arch/hexagon/include/asm/io.h
> >> +++ b/arch/hexagon/include/asm/io.h
> >> @@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
> >>
> >> void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
> >> #define ioremap_nocache ioremap
> >> -
> >> +#define ioremap_uc ioremap
> >>
> >> #define __raw_writel writel
> >
> > Do we really need this? There is only one user of ioremap_uc(), which
> > Christoph is trying hard to get rid of, and the new devres helper that
> > triggers all of this :-(
> > https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/
>
> One may ask why we needed a devres helper in the first place if there
> is indeed just one user.
Because of the new second user, which jumped on the devres train...
a8ff78f7f773142e ("mfd: intel-lpss: Use devm_ioremap_uc for MMIO").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-10 8:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 13:33 [PATCH] hexagon: io: Define ioremap_uc to fix build error Guenter Roeck
2019-12-09 14:40 ` Andy Shevchenko
2019-12-10 8:09 ` Geert Uytterhoeven
2019-12-10 8:23 ` Guenter Roeck
2019-12-10 8:45 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).