* [PATCH v2] video: fbdev: vesafb: add missed release_region
@ 2019-12-05 16:07 ` Chuhong Yuan
2020-01-15 14:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-12-05 16:07 UTC (permalink / raw)
Cc: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel,
Chuhong Yuan
The driver forgets to free the requested irq in remove and probe
failure.
Add the missed calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Modify commit message.
drivers/video/fbdev/vesafb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c
index d9c08f6c2155..fbb196a8bbf6 100644
--- a/drivers/video/fbdev/vesafb.c
+++ b/drivers/video/fbdev/vesafb.c
@@ -468,6 +468,7 @@ static int vesafb_probe(struct platform_device *dev)
fb_info(info, "%s frame buffer device\n", info->fix.id);
return 0;
err:
+ release_region(0x3c0, 32);
arch_phys_wc_del(par->wc_cookie);
if (info->screen_base)
iounmap(info->screen_base);
@@ -480,6 +481,7 @@ static int vesafb_remove(struct platform_device *pdev)
{
struct fb_info *info = platform_get_drvdata(pdev);
+ release_region(0x3c0, 32);
unregister_framebuffer(info);
framebuffer_release(info);
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] video: fbdev: vesafb: add missed release_region
2019-12-05 16:07 ` [PATCH v2] video: fbdev: vesafb: add missed release_region Chuhong Yuan
@ 2020-01-15 14:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-15 14:50 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: dri-devel, linux-fbdev, linux-kernel
On 12/5/19 5:07 PM, Chuhong Yuan wrote:
> The driver forgets to free the requested irq in remove and probe
> failure.
This is I/O region not IRQ.
> Add the missed calls to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
> - Modify commit message.
>
> drivers/video/fbdev/vesafb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c
> index d9c08f6c2155..fbb196a8bbf6 100644
> --- a/drivers/video/fbdev/vesafb.c
> +++ b/drivers/video/fbdev/vesafb.c
> @@ -468,6 +468,7 @@ static int vesafb_probe(struct platform_device *dev)
> fb_info(info, "%s frame buffer device\n", info->fix.id);
> return 0;
> err:
> + release_region(0x3c0, 32);
There is one 'goto err;' instance before request_region() which
needs to be taken care of first.
> arch_phys_wc_del(par->wc_cookie);
> if (info->screen_base)
> iounmap(info->screen_base);
> @@ -480,6 +481,7 @@ static int vesafb_remove(struct platform_device *pdev)
> {
> struct fb_info *info = platform_get_drvdata(pdev);
>
> + release_region(0x3c0, 32);
> unregister_framebuffer(info);
The order of operations on remove should be the reverse of
order of operations on probe.
[ We cannot release I/O region while framebuffer is active. ]
> framebuffer_release(info);
Please fix the patch and re-submit.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-15 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191205160725eucas1p226595a8d3043f48183a0a646bda61b4c@eucas1p2.samsung.com>
2019-12-05 16:07 ` [PATCH v2] video: fbdev: vesafb: add missed release_region Chuhong Yuan
2020-01-15 14:50 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).