* [PATCH] block: Make request_queue.rpm_status an enum
@ 2019-12-06 13:23 Geert Uytterhoeven
2019-12-09 12:18 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-12-06 13:23 UTC (permalink / raw)
To: Jens Axboe, Ming Lei, Rafael J . Wysocki
Cc: linux-pm, linux-kernel, Geert Uytterhoeven
request_queue.rpm_status is assigned values of the rpm_status enum only,
so reflect that in its type.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Perhaps this was done to avoid the need to #include <linux/pm.h>?
Let's see what kbuild has to report about this...
---
include/linux/blkdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 397bb9bc230b6349..6419cd9523c370f8 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -466,7 +466,7 @@ struct request_queue {
#ifdef CONFIG_PM
struct device *dev;
- int rpm_status;
+ enum rpm_status rpm_status;
unsigned int nr_pending;
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: Make request_queue.rpm_status an enum
2019-12-06 13:23 [PATCH] block: Make request_queue.rpm_status an enum Geert Uytterhoeven
@ 2019-12-09 12:18 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-12-09 12:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jens Axboe, Ming Lei, Rafael J . Wysocki, linux-pm, linux-kernel
On Friday, December 6, 2019 2:23:50 PM CET Geert Uytterhoeven wrote:
> request_queue.rpm_status is assigned values of the rpm_status enum only,
> so reflect that in its type.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> Perhaps this was done to avoid the need to #include <linux/pm.h>?
> Let's see what kbuild has to report about this...
> ---
> include/linux/blkdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 397bb9bc230b6349..6419cd9523c370f8 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -466,7 +466,7 @@ struct request_queue {
>
> #ifdef CONFIG_PM
> struct device *dev;
> - int rpm_status;
> + enum rpm_status rpm_status;
> unsigned int nr_pending;
> #endif
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-09 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 13:23 [PATCH] block: Make request_queue.rpm_status an enum Geert Uytterhoeven
2019-12-09 12:18 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).