* [PATCH v2]PM/wakeup: Add print_wakeup_source_stats(m, &deleted_ws)
@ 2019-12-09 9:35 zhuguangqing83
2019-12-20 9:19 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: zhuguangqing83 @ 2019-12-09 9:35 UTC (permalink / raw)
To: rjw; +Cc: pavel, len.brown, gregkh, linux-pm, linux-kernel, zhuguangqing
From: zhuguangqing <zhuguangqing@xiaomi.com>
After commit 00ee22c28915 (PM / wakeup: Use seq_open()
to show wakeup stats), print_wakeup_source_stats(m, &deleted_ws)
is deleted in function wakeup_sources_stats_seq_show().
Because deleted_ws is one of wakeup sources, so it should
also be showed. This patch add it to the end of all other
wakeup sources.
Signed-off-by: zhuguangqing <zhuguangqing@xiaomi.com>
---
v2: modify judegment condition according to the advice of Rafael J.
drivers/base/power/wakeup.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 5817b51d2b15..53c0519da1e4 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -1071,6 +1071,9 @@ static void *wakeup_sources_stats_seq_next(struct seq_file *m,
break;
}
+ if (!next_ws)
+ print_wakeup_source_stats(m, &deleted_ws);
+
return next_ws;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2]PM/wakeup: Add print_wakeup_source_stats(m, &deleted_ws)
2019-12-09 9:35 [PATCH v2]PM/wakeup: Add print_wakeup_source_stats(m, &deleted_ws) zhuguangqing83
@ 2019-12-20 9:19 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-12-20 9:19 UTC (permalink / raw)
To: zhuguangqing83
Cc: pavel, len.brown, gregkh, linux-pm, linux-kernel, zhuguangqing
On Monday, December 9, 2019 10:35:23 AM CET zhuguangqing83@gmail.com wrote:
> From: zhuguangqing <zhuguangqing@xiaomi.com>
>
> After commit 00ee22c28915 (PM / wakeup: Use seq_open()
> to show wakeup stats), print_wakeup_source_stats(m, &deleted_ws)
> is deleted in function wakeup_sources_stats_seq_show().
>
> Because deleted_ws is one of wakeup sources, so it should
> also be showed. This patch add it to the end of all other
> wakeup sources.
>
> Signed-off-by: zhuguangqing <zhuguangqing@xiaomi.com>
> ---
> v2: modify judegment condition according to the advice of Rafael J.
>
> drivers/base/power/wakeup.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
> index 5817b51d2b15..53c0519da1e4 100644
> --- a/drivers/base/power/wakeup.c
> +++ b/drivers/base/power/wakeup.c
> @@ -1071,6 +1071,9 @@ static void *wakeup_sources_stats_seq_next(struct seq_file *m,
> break;
> }
>
> + if (!next_ws)
> + print_wakeup_source_stats(m, &deleted_ws);
> +
> return next_ws;
> }
>
>
Applied as 5.6 material with some subject and changelog modifications, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-20 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 9:35 [PATCH v2]PM/wakeup: Add print_wakeup_source_stats(m, &deleted_ws) zhuguangqing83
2019-12-20 9:19 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).