* [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage
@ 2019-12-09 16:39 Krzysztof Kozlowski
2019-12-09 16:39 ` [PATCH 2/2] pinctrl: samsung: Clarify the option titles/names Krzysztof Kozlowski
2019-12-11 18:27 ` [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-09 16:39 UTC (permalink / raw)
To: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki,
Linus Walleij, linux-arm-kernel, linux-samsung-soc, linux-gpio,
linux-kernel
The Samsung pinctrl drivers require only GPIOLIB and OF for building.
The should be buildable on all architectures so enable COMPILE_TEST.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/pinctrl/samsung/Kconfig | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig
index 425fadd6c346..cbf1ce48fddb 100644
--- a/drivers/pinctrl/samsung/Kconfig
+++ b/drivers/pinctrl/samsung/Kconfig
@@ -9,7 +9,8 @@ config PINCTRL_SAMSUNG
config PINCTRL_EXYNOS
bool "Pinctrl driver data for Samsung EXYNOS SoCs"
- depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210)
+ depends on OF && GPIOLIB
+ depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST
select PINCTRL_SAMSUNG
select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210)
select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS
@@ -24,10 +25,11 @@ config PINCTRL_EXYNOS_ARM64
config PINCTRL_S3C24XX
bool "Samsung S3C24XX SoC pinctrl driver"
- depends on ARCH_S3C24XX && OF
+ depends on OF
+ depends on ARCH_S3C24XX || COMPILE_TEST
select PINCTRL_SAMSUNG
config PINCTRL_S3C64XX
bool "Samsung S3C64XX SoC pinctrl driver"
- depends on ARCH_S3C64XX
+ depends on ARCH_S3C64XX || COMPILE_TEST
select PINCTRL_SAMSUNG
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] pinctrl: samsung: Clarify the option titles/names
2019-12-09 16:39 [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage Krzysztof Kozlowski
@ 2019-12-09 16:39 ` Krzysztof Kozlowski
2019-12-13 16:01 ` Linus Walleij
2019-12-11 18:27 ` [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-09 16:39 UTC (permalink / raw)
To: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki,
Linus Walleij, linux-arm-kernel, linux-samsung-soc, linux-gpio,
linux-kernel
The config options toggle Samsung Exynos SoCs pinctrl drivers, not the
driver data. Clarify this in the option title/name and also make it
consistent with other Samsung entries. No functional change.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/pinctrl/samsung/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig
index cbf1ce48fddb..779c0e9eca3f 100644
--- a/drivers/pinctrl/samsung/Kconfig
+++ b/drivers/pinctrl/samsung/Kconfig
@@ -8,7 +8,7 @@ config PINCTRL_SAMSUNG
select PINCONF
config PINCTRL_EXYNOS
- bool "Pinctrl driver data for Samsung EXYNOS SoCs"
+ bool "Pinctrl common driver part for Samsung Exynos SoCs"
depends on OF && GPIOLIB
depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST
select PINCTRL_SAMSUNG
@@ -16,11 +16,11 @@ config PINCTRL_EXYNOS
select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS
config PINCTRL_EXYNOS_ARM
- bool "ARMv7-specific pinctrl driver data for Exynos" if COMPILE_TEST
+ bool "ARMv7-specific pinctrl driver for Samsung Exynos SoCs" if COMPILE_TEST
depends on PINCTRL_EXYNOS
config PINCTRL_EXYNOS_ARM64
- bool "ARMv8-specific pinctrl driver data for Exynos" if COMPILE_TEST
+ bool "ARMv8-specific pinctrl driver for Samsung Exynos SoCs" if COMPILE_TEST
depends on PINCTRL_EXYNOS
config PINCTRL_S3C24XX
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] pinctrl: samsung: Clarify the option titles/names
2019-12-09 16:39 ` [PATCH 2/2] pinctrl: samsung: Clarify the option titles/names Krzysztof Kozlowski
@ 2019-12-13 16:01 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2019-12-13 16:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Tomasz Figa, Sylwester Nawrocki, Linux ARM, linux-samsung-soc,
open list:GPIO SUBSYSTEM, linux-kernel
On Mon, Dec 9, 2019 at 5:40 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The config options toggle Samsung Exynos SoCs pinctrl drivers, not the
> driver data. Clarify this in the option title/name and also make it
> consistent with other Samsung entries. No functional change.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Like the other Samsung patch this doesn't apply to my tree
devel branch which is close to v5.5-rc1.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage
2019-12-09 16:39 [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage Krzysztof Kozlowski
2019-12-09 16:39 ` [PATCH 2/2] pinctrl: samsung: Clarify the option titles/names Krzysztof Kozlowski
@ 2019-12-11 18:27 ` Krzysztof Kozlowski
2019-12-13 16:03 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-11 18:27 UTC (permalink / raw)
To: Tomasz Figa, Sylwester Nawrocki, Linus Walleij, linux-arm-kernel,
linux-samsung-soc, linux-gpio, linux-kernel
On Mon, Dec 09, 2019 at 05:39:36PM +0100, Krzysztof Kozlowski wrote:
> The Samsung pinctrl drivers require only GPIOLIB and OF for building.
> The should be buildable on all architectures so enable COMPILE_TEST.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/pinctrl/samsung/Kconfig | 8 +++++---
Applied both to my tree. I'll send them to you Linus later in pull
request (unless 0-day catches some build failures).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage
2019-12-11 18:27 ` [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage Krzysztof Kozlowski
@ 2019-12-13 16:03 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2019-12-13 16:03 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Tomasz Figa, Sylwester Nawrocki, Linux ARM, linux-samsung-soc,
open list:GPIO SUBSYSTEM, linux-kernel
On Wed, Dec 11, 2019 at 7:27 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Mon, Dec 09, 2019 at 05:39:36PM +0100, Krzysztof Kozlowski wrote:
> > The Samsung pinctrl drivers require only GPIOLIB and OF for building.
> > The should be buildable on all architectures so enable COMPILE_TEST.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > drivers/pinctrl/samsung/Kconfig | 8 +++++---
>
> Applied both to my tree. I'll send them to you Linus later in pull
> request (unless 0-day catches some build failures).
Ah I see OK that's fine, forget my comments about not being able
to apply patches then, I'll just wait for the pull request :)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-13 20:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 16:39 [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage Krzysztof Kozlowski
2019-12-09 16:39 ` [PATCH 2/2] pinctrl: samsung: Clarify the option titles/names Krzysztof Kozlowski
2019-12-13 16:01 ` Linus Walleij
2019-12-11 18:27 ` [PATCH 1/2] pinctrl: samsung: Enable compile test for build coverage Krzysztof Kozlowski
2019-12-13 16:03 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).