* [PATCH] drm/bridge: panel: export drm_panel_bridge_connector
[not found] <20191207140353.23967-5-sam@ravnborg.org>
@ 2019-12-10 14:48 ` Mihail Atanassov
2019-12-10 16:26 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Mihail Atanassov @ 2019-12-10 14:48 UTC (permalink / raw)
To: dri-devel
Cc: Mihail Atanassov, nd, Sam Ravnborg, Laurent Pinchart,
Linux Walleij, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
linux-kernel
The function was unexported and was causing link failures for pl111 (and
probably the other user tve200) in a module build.
Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper")
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Linux Walleij <linux.walleij@linaro.org>
Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
drivers/gpu/drm/bridge/panel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 1443897f999b..f66777e24968 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -306,3 +306,4 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
return &panel_bridge->connector;
}
+EXPORT_SYMBOL(drm_panel_bridge_connector);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector
2019-12-10 14:48 ` [PATCH] drm/bridge: panel: export drm_panel_bridge_connector Mihail Atanassov
@ 2019-12-10 16:26 ` Laurent Pinchart
2019-12-10 17:28 ` Mihail Atanassov
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2019-12-10 16:26 UTC (permalink / raw)
To: Mihail Atanassov
Cc: dri-devel, nd, Sam Ravnborg, Linux Walleij, Andrzej Hajda,
Neil Armstrong, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, linux-kernel
Hi Mihail,
Thank you for the patch.
On Tue, Dec 10, 2019 at 02:48:49PM +0000, Mihail Atanassov wrote:
> The function was unexported and was causing link failures for pl111 (and
> probably the other user tve200) in a module build.
>
> Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper")
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linux Walleij <linux.walleij@linaro.org>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/panel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 1443897f999b..f66777e24968 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -306,3 +306,4 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
>
> return &panel_bridge->connector;
> }
> +EXPORT_SYMBOL(drm_panel_bridge_connector);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector
2019-12-10 16:26 ` Laurent Pinchart
@ 2019-12-10 17:28 ` Mihail Atanassov
0 siblings, 0 replies; 3+ messages in thread
From: Mihail Atanassov @ 2019-12-10 17:28 UTC (permalink / raw)
To: Laurent Pinchart, Sam Ravnborg
Cc: nd, dri-devel, Linux Walleij, Andrzej Hajda, Neil Armstrong,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
linux-kernel
On Tuesday, 10 December 2019 16:26:47 GMT Laurent Pinchart wrote:
> Hi Mihail,
>
> Thank you for the patch.
>
> On Tue, Dec 10, 2019 at 02:48:49PM +0000, Mihail Atanassov wrote:
> > The function was unexported and was causing link failures for pl111 (and
> > probably the other user tve200) in a module build.
> >
> > Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper")
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Linux Walleij <linux.walleij@linaro.org>
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
Thanks, applied to drm-misc-next.
> > ---
> > drivers/gpu/drm/bridge/panel.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 1443897f999b..f66777e24968 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -306,3 +306,4 @@ struct drm_connector *drm_panel_bridge_connector(struct drm_bridge *bridge)
> >
> > return &panel_bridge->connector;
> > }
> > +EXPORT_SYMBOL(drm_panel_bridge_connector);
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Mihail
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-10 17:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191207140353.23967-5-sam@ravnborg.org>
2019-12-10 14:48 ` [PATCH] drm/bridge: panel: export drm_panel_bridge_connector Mihail Atanassov
2019-12-10 16:26 ` Laurent Pinchart
2019-12-10 17:28 ` Mihail Atanassov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).