* [PATCH] arm64: dts: ls1028a: fix reboot node
@ 2019-11-23 0:07 Michael Walle
2019-12-09 3:46 ` Shawn Guo
2019-12-09 3:47 ` Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Michael Walle @ 2019-11-23 0:07 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Michael Walle
The reboot register isn't located inside the DCFG controller, but in its
own RST controller. Fix it.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 72b9a75976a1..dc75534a4754 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -102,7 +102,7 @@
reboot {
compatible ="syscon-reboot";
- regmap = <&dcfg>;
+ regmap = <&rst>;
offset = <0xb0>;
mask = <0x02>;
};
@@ -161,6 +161,12 @@
big-endian;
};
+ rst: syscon@1e60000 {
+ compatible = "fsl,ls1028a-rst", "syscon";
+ reg = <0x0 0x1e60000 0x0 0x10000>;
+ little-endian;
+ };
+
scfg: syscon@1fc0000 {
compatible = "fsl,ls1028a-scfg", "syscon";
reg = <0x0 0x1fc0000 0x0 0x10000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: fix reboot node
2019-11-23 0:07 [PATCH] arm64: dts: ls1028a: fix reboot node Michael Walle
@ 2019-12-09 3:46 ` Shawn Guo
2019-12-09 3:47 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-12-09 3:46 UTC (permalink / raw)
To: Michael Walle, Li Yang
Cc: linux-arm-kernel, devicetree, linux-kernel, Rob Herring, Mark Rutland
On Sat, Nov 23, 2019 at 01:07:09AM +0100, Michael Walle wrote:
> The reboot register isn't located inside the DCFG controller, but in its
> own RST controller. Fix it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Do we need a Fixes tag?
@Leo, looks good to you?
Shawn
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 72b9a75976a1..dc75534a4754 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -102,7 +102,7 @@
>
> reboot {
> compatible ="syscon-reboot";
> - regmap = <&dcfg>;
> + regmap = <&rst>;
> offset = <0xb0>;
> mask = <0x02>;
> };
> @@ -161,6 +161,12 @@
> big-endian;
> };
>
> + rst: syscon@1e60000 {
> + compatible = "fsl,ls1028a-rst", "syscon";
> + reg = <0x0 0x1e60000 0x0 0x10000>;
> + little-endian;
> + };
> +
> scfg: syscon@1fc0000 {
> compatible = "fsl,ls1028a-scfg", "syscon";
> reg = <0x0 0x1fc0000 0x0 0x10000>;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: fix reboot node
2019-11-23 0:07 [PATCH] arm64: dts: ls1028a: fix reboot node Michael Walle
2019-12-09 3:46 ` Shawn Guo
@ 2019-12-09 3:47 ` Shawn Guo
2019-12-09 9:02 ` Michael Walle
1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2019-12-09 3:47 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
On Sat, Nov 23, 2019 at 01:07:09AM +0100, Michael Walle wrote:
> The reboot register isn't located inside the DCFG controller, but in its
> own RST controller. Fix it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 72b9a75976a1..dc75534a4754 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -102,7 +102,7 @@
>
> reboot {
> compatible ="syscon-reboot";
> - regmap = <&dcfg>;
> + regmap = <&rst>;
> offset = <0xb0>;
> mask = <0x02>;
> };
> @@ -161,6 +161,12 @@
> big-endian;
> };
>
> + rst: syscon@1e60000 {
> + compatible = "fsl,ls1028a-rst", "syscon";
Compatible "fsl,ls1028a-rst" seems undocumented?
Shawn
> + reg = <0x0 0x1e60000 0x0 0x10000>;
> + little-endian;
> + };
> +
> scfg: syscon@1fc0000 {
> compatible = "fsl,ls1028a-scfg", "syscon";
> reg = <0x0 0x1fc0000 0x0 0x10000>;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: fix reboot node
2019-12-09 3:47 ` Shawn Guo
@ 2019-12-09 9:02 ` Michael Walle
2019-12-11 2:17 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Michael Walle @ 2019-12-09 9:02 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
Am 2019-12-09 04:47, schrieb Shawn Guo:
> On Sat, Nov 23, 2019 at 01:07:09AM +0100, Michael Walle wrote:
>> The reboot register isn't located inside the DCFG controller, but in
>> its
>> own RST controller. Fix it.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 72b9a75976a1..dc75534a4754 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -102,7 +102,7 @@
>>
>> reboot {
>> compatible ="syscon-reboot";
>> - regmap = <&dcfg>;
>> + regmap = <&rst>;
>> offset = <0xb0>;
>> mask = <0x02>;
>> };
>> @@ -161,6 +161,12 @@
>> big-endian;
>> };
>>
>> + rst: syscon@1e60000 {
>> + compatible = "fsl,ls1028a-rst", "syscon";
>
> Compatible "fsl,ls1028a-rst" seems undocumented?
it is the same with fsl,ls1028a-scfg and fsl,ls1028a-dcfg. So maybe I
should just drop the "fsl,ls1028a-rst". What do you think?
-michael
>
> Shawn
>
>> + reg = <0x0 0x1e60000 0x0 0x10000>;
>> + little-endian;
>> + };
>> +
>> scfg: syscon@1fc0000 {
>> compatible = "fsl,ls1028a-scfg", "syscon";
>> reg = <0x0 0x1fc0000 0x0 0x10000>;
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: fix reboot node
2019-12-09 9:02 ` Michael Walle
@ 2019-12-11 2:17 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-12-11 2:17 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
On Mon, Dec 09, 2019 at 10:02:02AM +0100, Michael Walle wrote:
> Am 2019-12-09 04:47, schrieb Shawn Guo:
> >On Sat, Nov 23, 2019 at 01:07:09AM +0100, Michael Walle wrote:
> >>The reboot register isn't located inside the DCFG controller,
> >>but in its
> >>own RST controller. Fix it.
> >>
> >>Signed-off-by: Michael Walle <michael@walle.cc>
> >>---
> >> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
> >> 1 file changed, 7 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >>b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >>index 72b9a75976a1..dc75534a4754 100644
> >>--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >>+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> >>@@ -102,7 +102,7 @@
> >>
> >> reboot {
> >> compatible ="syscon-reboot";
> >>- regmap = <&dcfg>;
> >>+ regmap = <&rst>;
> >> offset = <0xb0>;
> >> mask = <0x02>;
> >> };
> >>@@ -161,6 +161,12 @@
> >> big-endian;
> >> };
> >>
> >>+ rst: syscon@1e60000 {
> >>+ compatible = "fsl,ls1028a-rst", "syscon";
> >
> >Compatible "fsl,ls1028a-rst" seems undocumented?
>
> it is the same with fsl,ls1028a-scfg and fsl,ls1028a-dcfg. So maybe
> I should just drop the "fsl,ls1028a-rst". What do you think?
Drop it or document it. I'm fine with either way.
Shawn
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-11 2:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-23 0:07 [PATCH] arm64: dts: ls1028a: fix reboot node Michael Walle
2019-12-09 3:46 ` Shawn Guo
2019-12-09 3:47 ` Shawn Guo
2019-12-09 9:02 ` Michael Walle
2019-12-11 2:17 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).