* [PATCH v2] arm64: dts: ls1028a: fix reboot node
@ 2019-12-09 18:46 Michael Walle
2019-12-09 19:50 ` Leo Li
2019-12-11 7:52 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Michael Walle @ 2019-12-09 18:46 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Michael Walle
The reboot register isn't located inside the DCFG controller, but in its
own RST controller. Fix it.
Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
Signed-off-by: Michael Walle <michael@walle.cc>
---
changes since v1:
- add fixes tag
- remove "ls1028a-rst" compatible string, because there is no actual
driver for it. It just use the syscon driver.
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 8b28fda2ca20..7825550b7cef 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -88,7 +88,7 @@
reboot {
compatible ="syscon-reboot";
- regmap = <&dcfg>;
+ regmap = <&rst>;
offset = <0xb0>;
mask = <0x02>;
};
@@ -178,6 +178,12 @@
little-endian;
};
+ rst: syscon@1e60000 {
+ compatible = "syscon";
+ reg = <0x0 0x1e60000 0x0 0x10000>;
+ little-endian;
+ };
+
scfg: syscon@1fc0000 {
compatible = "fsl,ls1028a-scfg", "syscon";
reg = <0x0 0x1fc0000 0x0 0x10000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2] arm64: dts: ls1028a: fix reboot node
2019-12-09 18:46 [PATCH v2] arm64: dts: ls1028a: fix reboot node Michael Walle
@ 2019-12-09 19:50 ` Leo Li
2019-12-11 7:52 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Leo Li @ 2019-12-09 19:50 UTC (permalink / raw)
To: Michael Walle, linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Rob Herring, Mark Rutland
> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Monday, December 9, 2019 12:47 PM
> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
> Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> Michael Walle <michael@walle.cc>
> Subject: [PATCH v2] arm64: dts: ls1028a: fix reboot node
>
> The reboot register isn't located inside the DCFG controller, but in its own RST
> controller. Fix it.
>
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@walle.cc>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
>
> changes since v1:
> - add fixes tag
> - remove "ls1028a-rst" compatible string, because there is no actual
> driver for it. It just use the syscon driver.
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8b28fda2ca20..7825550b7cef 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -88,7 +88,7 @@
>
> reboot {
> compatible ="syscon-reboot";
> - regmap = <&dcfg>;
> + regmap = <&rst>;
> offset = <0xb0>;
> mask = <0x02>;
> };
> @@ -178,6 +178,12 @@
> little-endian;
> };
>
> + rst: syscon@1e60000 {
> + compatible = "syscon";
> + reg = <0x0 0x1e60000 0x0 0x10000>;
> + little-endian;
> + };
> +
> scfg: syscon@1fc0000 {
> compatible = "fsl,ls1028a-scfg", "syscon";
> reg = <0x0 0x1fc0000 0x0 0x10000>;
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: ls1028a: fix reboot node
2019-12-09 18:46 [PATCH v2] arm64: dts: ls1028a: fix reboot node Michael Walle
2019-12-09 19:50 ` Leo Li
@ 2019-12-11 7:52 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-12-11 7:52 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
On Mon, Dec 09, 2019 at 07:46:44PM +0100, Michael Walle wrote:
> The reboot register isn't located inside the DCFG controller, but in its
> own RST controller. Fix it.
>
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>
> changes since v1:
> - add fixes tag
> - remove "ls1028a-rst" compatible string, because there is no actual
> driver for it. It just use the syscon driver.
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8b28fda2ca20..7825550b7cef 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -88,7 +88,7 @@
>
> reboot {
> compatible ="syscon-reboot";
> - regmap = <&dcfg>;
> + regmap = <&rst>;
> offset = <0xb0>;
> mask = <0x02>;
> };
> @@ -178,6 +178,12 @@
> little-endian;
> };
>
> + rst: syscon@1e60000 {
> + compatible = "syscon";
> + reg = <0x0 0x1e60000 0x0 0x10000>;
> + little-endian;
> + };
> +
> scfg: syscon@1fc0000 {
Hmm, what is your base? It doesn't apply to my branch.
Shawn
> compatible = "fsl,ls1028a-scfg", "syscon";
> reg = <0x0 0x1fc0000 0x0 0x10000>;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-11 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 18:46 [PATCH v2] arm64: dts: ls1028a: fix reboot node Michael Walle
2019-12-09 19:50 ` Leo Li
2019-12-11 7:52 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).