linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: pwm: allwinner: Fix missing header in H6 example
@ 2019-12-10 17:47 Clément Péron
  2019-12-11  8:06 ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Clément Péron @ 2019-12-10 17:47 UTC (permalink / raw)
  To: Rob Herring, Maxime Ripard
  Cc: Thierry Reding, Uwe Kleine-König, Chen-Yu Tsai, linux-pwm,
	devicetree, linux-arm-kernel, linux-kernel,
	Clément Péron, Rob Herring

Latest linux-next doesn't build due to the following error:

Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
Error 1

This is due to missing header in the device-tree yaml example.

Fix this by adding the missing headers.

Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
index a7dc19fc347a..fab89f052450 100644
--- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
@@ -93,6 +93,9 @@ examples:
     };
 
   - |
+    #include <dt-bindings/clock/sun50i-h6-ccu.h>
+    #include <dt-bindings/reset/sun50i-h6-ccu.h>
+
     pwm@300a000 {
       compatible = "allwinner,sun50i-h6-pwm";
       reg = <0x0300a000 0x400>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: pwm: allwinner: Fix missing header in H6 example
  2019-12-10 17:47 [PATCH] dt-bindings: pwm: allwinner: Fix missing header in H6 example Clément Péron
@ 2019-12-11  8:06 ` Maxime Ripard
  2019-12-11  8:33   ` Chen-Yu Tsai
  0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2019-12-11  8:06 UTC (permalink / raw)
  To: Clément Péron
  Cc: Rob Herring, Thierry Reding, Uwe Kleine-König, Chen-Yu Tsai,
	linux-pwm, devicetree, linux-arm-kernel, linux-kernel,
	Rob Herring

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

On Tue, Dec 10, 2019 at 06:47:10PM +0100, Clément Péron wrote:
> Latest linux-next doesn't build due to the following error:
>
> Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
> Error 1
>
> This is due to missing header in the device-tree yaml example.
>
> Fix this by adding the missing headers.
>
> Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

Applied, thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: pwm: allwinner: Fix missing header in H6 example
  2019-12-11  8:06 ` Maxime Ripard
@ 2019-12-11  8:33   ` Chen-Yu Tsai
  2019-12-11  9:20     ` Maxime Ripard
  0 siblings, 1 reply; 4+ messages in thread
From: Chen-Yu Tsai @ 2019-12-11  8:33 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Clément Péron, Rob Herring, Thierry Reding,
	Uwe Kleine-König, linux-pwm, devicetree, linux-arm-kernel,
	linux-kernel, Rob Herring

On Wed, Dec 11, 2019 at 4:06 PM Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Tue, Dec 10, 2019 at 06:47:10PM +0100, Clément Péron wrote:
> > Latest linux-next doesn't build due to the following error:
> >
> > Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
> > syntax error
> > FATAL ERROR: Unable to parse input tree
> > make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
> > Error 1
> >
> > This is due to missing header in the device-tree yaml example.
> >
> > Fix this by adding the missing headers.
> >
> > Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
> > Reported-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
>
> Applied, thanks!
> Maxime

Maybe squash it instead? :)

ChenYu

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: pwm: allwinner: Fix missing header in H6 example
  2019-12-11  8:33   ` Chen-Yu Tsai
@ 2019-12-11  9:20     ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2019-12-11  9:20 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Clément Péron, Rob Herring, Thierry Reding,
	Uwe Kleine-König, linux-pwm, devicetree, linux-arm-kernel,
	linux-kernel, Rob Herring

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

On Wed, Dec 11, 2019 at 04:33:19PM +0800, Chen-Yu Tsai wrote:
> On Wed, Dec 11, 2019 at 4:06 PM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Tue, Dec 10, 2019 at 06:47:10PM +0100, Clément Péron wrote:
> > > Latest linux-next doesn't build due to the following error:
> > >
> > > Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
> > > syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
> > > Error 1
> > >
> > > This is due to missing header in the device-tree yaml example.
> > >
> > > Fix this by adding the missing headers.
> > >
> > > Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
> > > Reported-by: Rob Herring <robh+dt@kernel.org>
> > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> >
> > Applied, thanks!
> > Maxime
>
> Maybe squash it instead? :)

Indeed, I just did.

Thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-12-11  9:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 17:47 [PATCH] dt-bindings: pwm: allwinner: Fix missing header in H6 example Clément Péron
2019-12-11  8:06 ` Maxime Ripard
2019-12-11  8:33   ` Chen-Yu Tsai
2019-12-11  9:20     ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).