* [PATCH v3] arm64: dts: ls1028a: fix reboot node
@ 2019-12-11 17:11 Michael Walle
2019-12-12 2:00 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Michael Walle @ 2019-12-11 17:11 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Mark Rutland, Michael Walle
The reboot register isn't located inside the DCFG controller, but in its
own RST controller. Fix it.
Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
Signed-off-by: Michael Walle <michael@walle.cc>
---
changes since v2:
- rebase to shawnguo/linux/for-next
changes since v1:
- add fixes tag
- remove "ls1028a-rst" compatible string, because there is no actual
driver for it. It just use the syscon driver.
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 261663f4a2db..301a76e441fc 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -88,7 +88,7 @@
reboot {
compatible ="syscon-reboot";
- regmap = <&dcfg>;
+ regmap = <&rst>;
offset = <0xb0>;
mask = <0x02>;
};
@@ -178,6 +178,12 @@
big-endian;
};
+ rst: syscon@1e60000 {
+ compatible = "syscon";
+ reg = <0x0 0x1e60000 0x0 0x10000>;
+ little-endian;
+ };
+
scfg: syscon@1fc0000 {
compatible = "fsl,ls1028a-scfg", "syscon";
reg = <0x0 0x1fc0000 0x0 0x10000>;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] arm64: dts: ls1028a: fix reboot node
2019-12-11 17:11 [PATCH v3] arm64: dts: ls1028a: fix reboot node Michael Walle
@ 2019-12-12 2:00 ` Shawn Guo
2019-12-12 7:34 ` Michael Walle
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2019-12-12 2:00 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
On Wed, Dec 11, 2019 at 06:11:45PM +0100, Michael Walle wrote:
> The reboot register isn't located inside the DCFG controller, but in its
> own RST controller. Fix it.
>
> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
> Signed-off-by: Michael Walle <michael@walle.cc>
You missed Leo's ACK on v2? I added it and applied the patch.
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] arm64: dts: ls1028a: fix reboot node
2019-12-12 2:00 ` Shawn Guo
@ 2019-12-12 7:34 ` Michael Walle
0 siblings, 0 replies; 3+ messages in thread
From: Michael Walle @ 2019-12-12 7:34 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Mark Rutland
Am 2019-12-12 03:00, schrieb Shawn Guo:
> On Wed, Dec 11, 2019 at 06:11:45PM +0100, Michael Walle wrote:
>> The reboot register isn't located inside the DCFG controller, but in
>> its
>> own RST controller. Fix it.
>>
>> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")
>> Signed-off-by: Michael Walle <michael@walle.cc>
>
> You missed Leo's ACK on v2? I added it and applied the patch.
Yes, I forgot to add that, thanks.
-michael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-12 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 17:11 [PATCH v3] arm64: dts: ls1028a: fix reboot node Michael Walle
2019-12-12 2:00 ` Shawn Guo
2019-12-12 7:34 ` Michael Walle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).