linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Christian Bundy <christianbundy@fraction.io>,
	Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	stable <stable@vger.kernel.org>,
	linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init
Date: Wed, 11 Dec 2019 16:49:29 -0700	[thread overview]
Message-ID: <20191211234929.in7mrh3wq4pkhvsm@cantor> (raw)
In-Reply-To: <CAPcyv4iwJoX6tVVBUc0dSwHUwsu2duoUFayOnAhDEd5SjYug8g@mail.gmail.com>

On Wed Dec 11 19, Dan Williams wrote:
>On Wed, Dec 11, 2019 at 3:27 PM Jerry Snitselaar <jsnitsel@redhat.com> wrote:
>>
>> On Wed Dec 11 19, Jerry Snitselaar wrote:
>> >Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when
>> >issuing commands to the tpm during initialization, just reserve the
>> >chip after wait_startup, and release it when we are ready to call
>> >tpm_chip_register.
>> >
>> >Cc: Christian Bundy <christianbundy@fraction.io>
>> >Cc: Dan Williams <dan.j.williams@intel.com>
>> >Cc: Peter Huewe <peterhuewe@gmx.de>
>> >Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>> >Cc: Jason Gunthorpe <jgg@ziepe.ca>
>> >Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
>> >Cc: stable@vger.kernel.org
>> >Cc: linux-intergrity@vger.kernel.org
>>
>> Typo on the list address, do you want me to resend Jarkko?
>>
>> >Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
>> >Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
>> >---
>>
>> I did some initial testing with both a 1.2 device and a 2.0 device here.
>> Christian, can you verify that this still solves your timeouts problem
>> you were seeing? Dan, can you try this on the internal system with
>> the interrupt issues? I will see if I can get the t490s owner to run
>> it as well.
>
>Will do. I assume you'd also want to add 'Fixes: 5b359c7c4372
>("tpm_tis_core: Turn on the TPM before probing IRQ's")' if it works?
>

Yes. I'm not certain this deals with the interrupt issue though, so
didn't want to stick it on there yet. I guess it should go on there
anyways since it is replacing that code. I'll post a v2.


  reply	other threads:[~2019-12-11 23:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 23:17 [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init Jerry Snitselaar
2019-12-11 23:26 ` Jerry Snitselaar
2019-12-11 23:30   ` Dan Williams
2019-12-11 23:49     ` Jerry Snitselaar [this message]
2019-12-11 23:54 ` [PATCH v2] " Jerry Snitselaar
2019-12-12  2:15   ` Dan Williams
2019-12-12  2:18     ` Dan Williams
2019-12-17  1:25       ` Jarkko Sakkinen
2019-12-17  0:58   ` Jarkko Sakkinen
2019-12-17  1:18     ` Dan Williams
2019-12-17  2:00       ` Jerry Snitselaar
2019-12-17  2:14         ` Dan Williams
2019-12-17 12:05           ` Jarkko Sakkinen
2019-12-17 17:18             ` Jerry Snitselaar
2019-12-17 17:26               ` Jerry Snitselaar
2019-12-18 23:09                 ` Jarkko Sakkinen
2019-12-18 23:06               ` Jarkko Sakkinen
2019-12-18 23:31                 ` Dan Williams
2019-12-19 10:07                   ` Jerry Snitselaar
2019-12-27  5:09                     ` Jarkko Sakkinen
2019-12-27  5:42                       ` Jarkko Sakkinen
2019-12-27  6:03                         ` Jarkko Sakkinen
2019-12-17 20:29             ` Jerry Snitselaar
2019-12-18 23:12               ` Jarkko Sakkinen
2019-12-17  1:19     ` Jarkko Sakkinen
2019-12-17  0:43 ` [PATCH] " Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211234929.in7mrh3wq4pkhvsm@cantor \
    --to=jsnitsel@redhat.com \
    --cc=christianbundy@fraction.io \
    --cc=dan.j.williams@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=stable@vger.kernel.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).