From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christian Bundy <christianbundy@fraction.io>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
stable <stable@vger.kernel.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init
Date: Fri, 27 Dec 2019 07:09:06 +0200 [thread overview]
Message-ID: <f0406ed23a9a64bd7c5dc0e0b403151d6157a8cf.camel@linux.intel.com> (raw)
In-Reply-To: <20191219100747.fhbqmzk7xby3tt3l@cantor>
On Thu, 2019-12-19 at 03:07 -0700, Jerry Snitselaar wrote:
> > These patches take a usable system and make it unusable:
> >
> > 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts
> > 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's
> >
> > ...they need to be reverted, or the regression needs to be fixed, but
> > asserting that you fixed something else unrelated does not help.
> >
>
> Reverting 1ea32c83c699 ("tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before
> probing for interrupts") would at least allow people impacted by this
> to boot their systems without disabling the tpm, or blacklisting the
> module while we figure this out. From what I can tell the tpm_tis code
> was operating in that state since 570a36097f30 ("tpm: drop 'irq' from
> struct tpm_vendor_specific") until Stefan's patch.
I'll formalize a fix based on the reverts.
Sorry for the holiday latency.
/Jarkko
next prev parent reply other threads:[~2019-12-27 5:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 23:17 [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init Jerry Snitselaar
2019-12-11 23:26 ` Jerry Snitselaar
2019-12-11 23:30 ` Dan Williams
2019-12-11 23:49 ` Jerry Snitselaar
2019-12-11 23:54 ` [PATCH v2] " Jerry Snitselaar
2019-12-12 2:15 ` Dan Williams
2019-12-12 2:18 ` Dan Williams
2019-12-17 1:25 ` Jarkko Sakkinen
2019-12-17 0:58 ` Jarkko Sakkinen
2019-12-17 1:18 ` Dan Williams
2019-12-17 2:00 ` Jerry Snitselaar
2019-12-17 2:14 ` Dan Williams
2019-12-17 12:05 ` Jarkko Sakkinen
2019-12-17 17:18 ` Jerry Snitselaar
2019-12-17 17:26 ` Jerry Snitselaar
2019-12-18 23:09 ` Jarkko Sakkinen
2019-12-18 23:06 ` Jarkko Sakkinen
2019-12-18 23:31 ` Dan Williams
2019-12-19 10:07 ` Jerry Snitselaar
2019-12-27 5:09 ` Jarkko Sakkinen [this message]
2019-12-27 5:42 ` Jarkko Sakkinen
2019-12-27 6:03 ` Jarkko Sakkinen
2019-12-17 20:29 ` Jerry Snitselaar
2019-12-18 23:12 ` Jarkko Sakkinen
2019-12-17 1:19 ` Jarkko Sakkinen
2019-12-17 0:43 ` [PATCH] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0406ed23a9a64bd7c5dc0e0b403151d6157a8cf.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=christianbundy@fraction.io \
--cc=dan.j.williams@intel.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).