* [PATCH v2] lib/stackdepot: Fix global out-of-bounds in stackdepot
@ 2019-12-12 11:58 Walter Wu
0 siblings, 0 replies; only message in thread
From: Walter Wu @ 2019-12-12 11:58 UTC (permalink / raw)
To: Matthias Brugger, Thomas Gleixner, Alexander Potapenko, Josh Poimboeuf
Cc: linux-kernel, linux-arm-kernel, linux-mediatek, wsd_upstream, Walter Wu
If the depot_index = STACK_ALLOC_MAX_SLABS - 2 and next_slab_inited = 0,
then it will cause array out-of-bounds access, so that we should modify
the detection to avoid this array out-of-bounds bug.
Assume depot_index = STACK_ALLOC_MAX_SLABS - 3
Consider following call flow sequence:
stack_depot_save()
depot_alloc_stack()
if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) //pass
depot_index++ //depot_index = STACK_ALLOC_MAX_SLABS - 2
if (depot_index + 1 < STACK_ALLOC_MAX_SLABS) //enter
smp_store_release(&next_slab_inited, 0); //next_slab_inited = 0
init_stack_slab()
if (stack_slabs[depot_index] == NULL) //enter
stack_depot_save()
depot_alloc_stack()
if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) //pass
depot_index++ //depot_index = STACK_ALLOC_MAX_SLABS - 1
init_stack_slab(&prealloc)
stack_slabs[depot_index + 1] //here get global out-of-bounds
Signed-off-by: Walter Wu <walter-zh.wu@mediatek.com>
---
changes in v2:
modify call flow sequence and preconditon
---
lib/stackdepot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index ed717dd08ff3..7e8a15e41600 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -106,7 +106,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
required_size = ALIGN(required_size, 1 << STACK_ALLOC_ALIGN);
if (unlikely(depot_offset + required_size > STACK_ALLOC_SIZE)) {
- if (unlikely(depot_index + 1 >= STACK_ALLOC_MAX_SLABS)) {
+ if (unlikely(depot_index + 2 >= STACK_ALLOC_MAX_SLABS)) {
WARN_ONCE(1, "Stack depot reached limit capacity");
return NULL;
}
--
2.18.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-12 11:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 11:58 [PATCH v2] lib/stackdepot: Fix global out-of-bounds in stackdepot Walter Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).