From: Johan Hovold <johan@kernel.org>
To: guillaume La Roque <glaroque@baylibre.com>
Cc: Johan Hovold <johan@kernel.org>,
marcel@holtmann.org, johan.hedberg@gmail.com,
linux-bluetooth@vger.kernel.org, nsaenzjulienne@suse.de,
linux-kernel@vger.kernel.org, khilman@baylibre.com
Subject: Re: [PATCH v4] bluetooth: hci_bcm: enable IRQ capability from node
Date: Fri, 13 Dec 2019 14:44:04 +0100 [thread overview]
Message-ID: <20191213134404.GY10631@localhost> (raw)
In-Reply-To: <162e5588-a702-6042-6934-dd41b64fa1dc@baylibre.com>
On Fri, Dec 13, 2019 at 01:31:18PM +0100, guillaume La Roque wrote:
> Hi Johan,
>
> On 12/13/19 12:17 PM, Johan Hovold wrote:
> > On Fri, Dec 13, 2019 at 11:55:21AM +0100, Guillaume La Roque wrote:
> >> @@ -1421,6 +1422,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
> >> #endif
> >> bcmdev->serdev_hu.serdev = serdev;
> >> serdev_device_set_drvdata(serdev, bcmdev);
> >> + bcmdev->irq = of_irq_get(bcmdev->dev->of_node, 0);
> > Shouldn't you be used using of_irq_get_byname()?
> i can use it if you prefer but no other interrupt need to be defined
Maybe not needed then. Was just thinking it may make it more clear that
you now have two ways to specify the "host-wakeup" interrupt (and in
your proposed implementation the interrupts-property happens to take
priority). Perhaps that can be sorted out when you submit the binding
update for review.
Johan
next prev parent reply other threads:[~2019-12-13 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 10:55 [PATCH v4] bluetooth: hci_bcm: enable IRQ capability from node Guillaume La Roque
2019-12-13 11:17 ` Johan Hovold
2019-12-13 12:31 ` guillaume La Roque
2019-12-13 13:44 ` Johan Hovold [this message]
2019-12-13 14:07 ` guillaume La Roque
2020-01-04 9:58 ` Marcel Holtmann
2020-01-07 12:33 ` guillaume La Roque
2020-01-08 20:53 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213134404.GY10631@localhost \
--to=johan@kernel.org \
--cc=glaroque@baylibre.com \
--cc=johan.hedberg@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).