linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Guillaume La Roque <glaroque@baylibre.com>
Cc: Johan Hovold <johan@kernel.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	BlueZ devel list <linux-bluetooth@vger.kernel.org>,
	nsaenzjulienne@suse.de, linux-kernel@vger.kernel.org,
	khilman@baylibre.com
Subject: Re: [PATCH v4] bluetooth: hci_bcm: enable IRQ capability from node
Date: Sat, 4 Jan 2020 10:58:53 +0100	[thread overview]
Message-ID: <8EBBCE1B-688D-4097-A2AF-6E099A0AD68B@holtmann.org> (raw)
In-Reply-To: <08ae6108-0829-3bb4-f398-7e6a58719d29@baylibre.com>

Hi Guillaume,

>>>>> @@ -1421,6 +1422,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
>>>>> #endif
>>>>> 	bcmdev->serdev_hu.serdev = serdev;
>>>>> 	serdev_device_set_drvdata(serdev, bcmdev);
>>>>> +	bcmdev->irq = of_irq_get(bcmdev->dev->of_node, 0);
>>>> Shouldn't you be used using of_irq_get_byname()?
>>> i can use it if you prefer but no other interrupt need to be defined
>> Maybe not needed then. Was just thinking it may make it more clear that
>> you now have two ways to specify the "host-wakeup" interrupt (and in
>> your proposed implementation the interrupts-property happens to take
>> priority). Perhaps that can be sorted out when you submit the binding
>> update for review.
> 
> no problem i add a "host-wakeup" interrupt-name.
> you are right it will be more clear with name and we know why this interrupt is needed.

have I missed the v5 or are still sending it?

Regards

Marcel


  reply	other threads:[~2020-01-04  9:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 10:55 [PATCH v4] bluetooth: hci_bcm: enable IRQ capability from node Guillaume La Roque
2019-12-13 11:17 ` Johan Hovold
2019-12-13 12:31   ` guillaume La Roque
2019-12-13 13:44     ` Johan Hovold
2019-12-13 14:07       ` guillaume La Roque
2020-01-04  9:58         ` Marcel Holtmann [this message]
2020-01-07 12:33           ` guillaume La Roque
2020-01-08 20:53             ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8EBBCE1B-688D-4097-A2AF-6E099A0AD68B@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=glaroque@baylibre.com \
    --cc=johan.hedberg@gmail.com \
    --cc=johan@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsaenzjulienne@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).